Merge remote-tracking branch 'origin/main' into lv-find-min-max-index-tmp

Author: fhahn

bolt/lib/Passes/Inliner.cpp

@@ -491,32 +491,6 @@ bool Inliner::inlineCallsInFunction(BinaryFunction &Function) {
         }
       }
 
-      // AArch64 BTI:
-      // If the callee has an indirect tailcall (BR), we would transform it to
-      // an indirect call (BLR) in InlineCall. Because of this, we would have to
-      // update the BTI at the target of the tailcall. However, these targets
-      // are not known. Instead, we skip inlining blocks with indirect
-      // tailcalls.
-      auto HasIndirectTailCall = [&](const BinaryFunction &BF) -> bool {
-        for (const auto &BB : BF) {
-          for (const auto &II : BB) {
-            if (BC.MIB->isIndirectBranch(II) && BC.MIB->isTailCall(II)) {
-              return true;
-            }
-          }
-        }
-        return false;
-      };
-
-      if (BC.isAArch64() && BC.usesBTI() &&
-          HasIndirectTailCall(*TargetFunction)) {
-        ++InstIt;
-        LLVM_DEBUG(dbgs() << "BOLT-DEBUG: Skipping inlining block with tailcall"
-                          << " in " << Function << " : " << BB->getName()
-                          << " to keep BTIs consistent.\n");
-        continue;
-      }
-
       LLVM_DEBUG(dbgs() << "BOLT-DEBUG: inlining call to " << *TargetFunction
                         << " in " << Function << " : " << BB->getName()
                         << ". Count: " << BB->getKnownExecutionCount()

bolt/test/AArch64/inline-bti.s

@@ -45,11 +45,11 @@ Options
   Selects which set of functions is considered as asynchronous-safe
   (and therefore allowed in signal handlers). It can be set to the following values:
 
-  ``minimal``
+  - `minimal`
      Selects a minimal set that is defined in the CERT SIG30-C rule.
      and includes functions ``abort()``, ``_Exit()``, ``quick_exit()`` and
      ``signal()``.
-  ``POSIX``
+  - `POSIX`
      Selects a larger set of functions that is listed in POSIX.1-2017 (see `this
      link
      <https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03>`_
@@ -94,4 +94,4 @@ Options
      The function ``quick_exit`` is not included in the POSIX list but it
      is included here in the set of safe functions.
 
-  The default value is ``POSIX``.
+  The default value is `POSIX`.

clang-tools-extra/docs/clang-tidy/checks/bugprone/signal-handler.rst

@@ -51,6 +51,6 @@ Example:
    on non-enum types where the compiler warnings may not be present.
 
 .. seealso::
-   The `CppCoreGuideline ES.79 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-default>`_
+   The `CppCoreGuideline ES.79 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#res-default>`_
    provide guidelines on switch statements, including the recommendation to
    always provide a default case.

clang-tools-extra/docs/clang-tidy/checks/bugprone/switch-missing-default-case.rst

@@ -8,7 +8,7 @@ use-after-free errors and suggests avoiding captures or ensuring the lambda
 closure object has a guaranteed lifetime.
 
 This check implements `CP.51
-<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rcoro-capture>`_
+<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#rcoro-capture>`_
 from the C++ Core Guidelines.
 
 Using coroutine lambdas with non-empty capture lists can be risky, as capturing

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capturing-lambda-coroutines.rst

@@ -44,7 +44,7 @@ Examples:
   };
 
 This check implements `C.12
-<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-constref>`_
+<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#rc-constref>`_
 from the C++ Core Guidelines.
 
 Further reading:

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.rst

@@ -9,7 +9,7 @@ condition is not checked prior to the first iteration.
 This can lead to subtle bugs.
 
 This check implements `ES.75
-<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-do>`_
+<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#res-do>`_
 from the C++ Core Guidelines.
 
 Examples:

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-do-while.rst

@@ -6,7 +6,7 @@ cppcoreguidelines-avoid-non-const-global-variables
 Finds non-const global variables as described in `I.2
 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#i2-avoid-non-const-global-variables>`_
 of C++ Core Guidelines.
-As `R.6 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rr-global>`_
+As `R.6 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#rr-global>`_
 of C++ Core Guidelines is a duplicate of rule `I.2
 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#i2-avoid-non-const-global-variables>`_
 it also covers that rule.

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.rst

@@ -18,5 +18,5 @@ Examples:
   }
 
 This check implements `CP.53
-<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rcoro-reference-parameters>`_
+<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#rcoro-reference-parameters>`_
 from the C++ Core Guidelines.

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-reference-coroutine-parameters.rst

@@ -8,8 +8,8 @@ value. These may lead to unexpected behavior if there is a code path that reads
 the variable before assigning to it.
 
 This rule is part of the `Type safety (Type.5)
-<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Pro-type-init>`_
-profile and `ES.20 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always>`_
+<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#pro-type-init>`_
+profile and `ES.20 <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#res-always>`_
 from the C++ Core Guidelines.
 
 Only integers, booleans, floats, doubles and pointers are checked. The fix