review comment fixes

Author: VigneshwarJ

clang/lib/Sema/SemaDecl.cpp

@@ -8719,22 +8719,12 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
     if (FunctionDecl *FD = getCurFunctionDecl();
         FD &&
         (FD->hasAttr<CUDADeviceAttr>() || FD->hasAttr<CUDAGlobalAttr>())) {
-
-      auto Check = [&](QualType TypeToCheck, const VarDecl *VD) {
+      if (QualType NextTy = NewVD->getType(); NextTy->isArrayType()) {
         if (const ConstantArrayType *ArrayT =
-                getASTContext().getAsConstantArrayType(TypeToCheck);
+                getASTContext().getAsConstantArrayType(NextTy);
             ArrayT && ArrayT->isZeroSize()) {
-          Diag(VD->getLocation(), diag::err_typecheck_zero_array_size) << 2;
+          Diag(NewVD->getLocation(), diag::err_typecheck_zero_array_size) << 2;
         }
-      };
-      QualType NextTy = NewVD->getType();
-      while (NextTy->isAnyPointerType() || NextTy->isArrayType() ||
-             NextTy->isReferenceType()) {
-        if (NextTy->isArrayType()) {
-          Check(NextTy, NewVD);
-          break;
-        } else
-          NextTy = NextTy->getPointeeType();
       }
     }
   }

clang/test/SemaHIP/zero-sized-device-array.hip

@@ -11,7 +11,6 @@ __global__ void global_fun() {
     extern __shared__ float externArray[];
     ZEROARR TypeDef; // expected-error {{zero-length arrays are not permitted in HIP device code}}
     float array[0];  // expected-error {{zero-length arrays are not permitted in HIP device code}}
-    ZEROARR *Ptr;    // expected-error {{zero-length arrays are not permitted in HIP device code}}
 }
 
 // should not throw error for host side code.