fix review

Author: HerrCai0907

clang-tools-extra/clang-tidy/bugprone/UnintendedCharOstreamOutputCheck.cpp

@@ -19,20 +19,14 @@ namespace {
 
 // check if the type is unsigned char or signed char
 AST_MATCHER(Type, isNumericChar) {
-  const auto *BT = dyn_cast<BuiltinType>(&Node);
-  if (BT == nullptr)
-    return false;
-  const BuiltinType::Kind K = BT->getKind();
-  return K == BuiltinType::UChar || K == BuiltinType::SChar;
+  return Node.isSpecificBuiltinType(BuiltinType::SChar) ||
+         Node.isSpecificBuiltinType(BuiltinType::UChar);
 }
 
 // check if the type is char
 AST_MATCHER(Type, isChar) {
-  const auto *BT = dyn_cast<BuiltinType>(&Node);
-  if (BT == nullptr)
-    return false;
-  const BuiltinType::Kind K = BT->getKind();
-  return K == BuiltinType::Char_U || K == BuiltinType::Char_S;
+  return Node.isSpecificBuiltinType(BuiltinType::Char_S) ||
+         Node.isSpecificBuiltinType(BuiltinType::Char_U);
 }
 
 } // namespace

clang-tools-extra/docs/ReleaseNotes.rst

@@ -95,7 +95,7 @@ New checks
   <clang-tidy/checks/bugprone/unintended-char-ostream-output>` check.
 
   Finds unintended character output from ``unsigned char`` and ``signed char`` to an
-  ostream.
+  ``ostream``.
 
 New check aliases
 ^^^^^^^^^^^^^^^^^

clang-tools-extra/docs/clang-tidy/checks/bugprone/unintended-char-ostream-output.rst

@@ -14,8 +14,8 @@ integer values.
 
 .. code-block:: c++
 
-    uint8_t v = 9;
-    std::cout << v; // output '\t' instead of '9'
+    uint8_t v = 65;
+    std::cout << v; // output 'A' instead of '65'
 
 It could be fixed as
 

clang-tools-extra/test/clang-tidy/checkers/bugprone/unintended-char-ostream-output.cpp

@@ -30,13 +30,11 @@ class A : public std::ostream {};
 void origin_ostream(std::ostream &os) {
   unsigned char unsigned_value = 9;
   os << unsigned_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to
-  // 'operator<<' outputs as character instead of integer
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to 'operator<<' outputs as character instead of integer
 
   signed char signed_value = 9;
   os << signed_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'signed char' passed to
-  // 'operator<<' outputs as character instead of integer
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'signed char' passed to 'operator<<' outputs as character instead of integer
 
   char char_value = 9;
   os << char_value;
@@ -45,13 +43,11 @@ void origin_ostream(std::ostream &os) {
 void based_on_ostream(A &os) {
   unsigned char unsigned_value = 9;
   os << unsigned_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to
-  // 'operator<<' outputs as character instead of integer
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to 'operator<<' outputs as character instead of integer
 
   signed char signed_value = 9;
   os << signed_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'signed char' passed to
-  // 'operator<<' outputs as character instead of integer
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'signed char' passed to 'operator<<' outputs as character instead of integer
 
   char char_value = 9;
   os << char_value;
@@ -67,3 +63,11 @@ void based_on_ostream(std::basic_ostream<unsigned char> &os) {
   char char_value = 9;
   os << char_value;
 }
+
+template <class T> class B : public std::ostream {};
+void template_based_on_ostream(B<int> &os) {
+  unsigned char unsigned_value = 9;
+  os << unsigned_value;
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to 'operator<<' outputs as character instead of integer
+}
+