Reviwe feedback, fix vector test

Author: krzysz00

mlir/lib/Dialect/GPU/IR/ValueBoundsOpInterfaceImpl.cpp

@@ -35,7 +35,7 @@ struct GpuIdOpInterface
       cstr.bound(v) >= range.smin().getSExtValue();
       cstr.bound(v) <= range.smax().getSExtValue();
     };
-    // No arguments, so we don't need to pass in their ranges.
+    assert(inferrable->getNumOperands() == 0 && "ID ops have no operands");
     inferrable.inferResultRanges({}, translateConstraint);
   }
 };

mlir/test/Dialect/GPU/value-bounds-op-interface-impl.mlir

@@ -62,6 +62,9 @@ func.func @launch_func(%arg0 : index) {
     "test.compare"(%thread_id_z, %c0) {cmp = "GE"} : (index, index) -> ()
     // expected-remark @below{{true}}
     "test.compare"(%thread_id_z, %c2) {cmp = "LT"} : (index, index) -> ()
+
+    // expected-remark @below{{true}}
+    "test.compare"(%thread_id_x, %block_dim_x) {cmp = "LT"} : (index, index) -> ()
     gpu.terminator
   }
 
@@ -114,6 +117,8 @@ module attributes {gpu.container_module} {
       // expected-remark @below{{true}}
       "test.compare"(%block_dim_x, %c8) {cmp = "EQ"} : (index, index) -> ()
 
+      // expected-remark @below{{true}}
+      "test.compare"(%thread_id_x, %block_dim_x) {cmp = "LT"} : (index, index) -> ()
       gpu.return
     }
   }
@@ -144,6 +149,10 @@ module attributes {gpu.container_module} {
       // expected-remark @below{{true}}
       "test.compare"(%thread_id_x, %c8) {cmp = "LT"} : (index, index) -> ()
 
+      // Note: there isn't a way to express the ID <= size constraint
+      // in this form
+      // expected-error @below{{unknown}}
+      "test.compare"(%thread_id_x, %block_dim_x) {cmp = "LT"} : (index, index) -> ()
       gpu.return
     }
   }

mlir/test/Dialect/Vector/test-scalable-bounds.mlir

@@ -1,4 +1,4 @@
-// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(test-affine-reify-value-bounds))' -cse -verify-diagnostics \
+// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(test-affine-reify-value-bounds, cse))' -verify-diagnostics \
 // RUN:   -verify-diagnostics -split-input-file | FileCheck %s
 
 #map_dim_i = affine_map<(d0)[s0] -> (-d0 + 32400, s0)>