reduce destructor lookups

Author: cor3ntin

clang/lib/Sema/SemaDeclCXX.cpp

@@ -7381,7 +7381,7 @@ hasSuitableMoveAssignmentOperatorForRelocation(Sema &SemaRef, CXXRecordDecl *D,
 // type C selects an assignment operator function that is a direct member of C
 // and is neither user-provided nor deleted, and C has a destructor that is
 // neither user-provided nor deleted.
-static bool isDefaultMovable(Sema &SemaRef, CXXRecordDecl *D) {
+static bool isDefaultMovable(Sema &SemaRef, CXXRecordDecl *D, CXXDestructorDecl* Dtr) {
   if (!hasSuitableConstructorForRelocation(SemaRef, D,
                                            /*AllowUserDefined=*/false))
     return false;
@@ -7390,7 +7390,6 @@ static bool isDefaultMovable(Sema &SemaRef, CXXRecordDecl *D) {
           SemaRef, D, /*AllowUserDefined=*/false))
     return false;
 
-  const auto *Dtr = D->getDestructor();
   if (!Dtr)
     return true;
 
@@ -7426,9 +7425,7 @@ static bool isEligibleForTrivialRelocation(Sema &SemaRef, CXXRecordDecl *D) {
             SemaRef.getASTContext()))
       return false;
   }
-
-  // ...has a deleted destructor
-  return !D->hasDeletedDestructor();
+  return true;
 }
 
 // [C++26][class.prop]
@@ -7452,9 +7449,7 @@ static bool isEligibleForReplacement(Sema &SemaRef, CXXRecordDecl *D) {
     if (!Field->getType().isReplaceableType(SemaRef.getASTContext()))
       return false;
   }
-
-  // it has a deleted destructor.
-  return !D->hasDeletedDestructor();
+  return true;
 }
 
 void Sema::CheckCXX2CRelocatableAndReplaceable(CXXRecordDecl *D) {
@@ -7466,6 +7461,7 @@ void Sema::CheckCXX2CRelocatableAndReplaceable(CXXRecordDecl *D) {
   bool MarkedCXX2CReplaceable = D->hasAttr<ReplaceableAttr>();
   bool MarkedTriviallyRelocatable = D->hasAttr<TriviallyRelocatableAttr>();
 
+
   // This is part of "eligible for replacement", however we defer it
   // to avoid extraneous computations.
   auto HasSuitableSMP = [&] {
@@ -7484,9 +7480,15 @@ void Sema::CheckCXX2CRelocatableAndReplaceable(CXXRecordDecl *D) {
     return *Is;
   };
 
+  auto GetDestructor = [&, Dtr = static_cast<CXXDestructorDecl*>(nullptr)]() mutable {
+      if(!Dtr)
+          Dtr = D->getDestructor();
+      return Dtr;
+  };
+
   auto IsDefaultMovable = [&, Is = std::optional<bool>{}]() mutable {
     if (!Is.has_value())
-      Is = isDefaultMovable(*this, D);
+      Is = isDefaultMovable(*this, D, GetDestructor());
     return *Is;
   };
 
@@ -7498,6 +7500,9 @@ void Sema::CheckCXX2CRelocatableAndReplaceable(CXXRecordDecl *D) {
     if (!isEligibleForTrivialRelocation(*this, D))
       return false;
 
+    if(auto* Dtr = GetDestructor(); Dtr && Dtr->isDeleted())
+        return false;
+
     // has the trivially_relocatable_if_eligible class-property-specifier,
     if (MarkedTriviallyRelocatable)
       return true;
@@ -7520,6 +7525,9 @@ void Sema::CheckCXX2CRelocatableAndReplaceable(CXXRecordDecl *D) {
     if (!isEligibleForReplacement(*this, D))
       return false;
 
+    if(auto* Dtr = GetDestructor(); Dtr && Dtr->isDeleted())
+        return false;
+
     // has the replaceable_if_eligible class-property-specifier
     if (MarkedCXX2CReplaceable)
       return HasSuitableSMP();