Apply suggestions from code review

Co-authored-by: Kazu Hirata <[email protected]>

Author: mingmingl-llvm

llvm/include/llvm/ProfileData/DataAccessProf.h

@@ -97,7 +97,7 @@ class DataAccessProfData {
 
   /// Methods to add symbolized data access profile. Returns error if duplicated
   /// symbol names or content hashes are seen. The user of this class should
-  /// aggregate counters that corresponds to the same symbol name or with the
+  /// aggregate counters that correspond to the same symbol name or with the
   /// same string literal hash before calling 'add*' methods.
   Error setDataAccessProfile(SymbolID SymbolID, uint64_t AccessCount);
   /// Similar to the method above, for records with \p Locations representing
@@ -108,23 +108,24 @@ class DataAccessProfData {
                              const llvm::SmallVector<DataLocation> &Locations);
   Error addKnownSymbolWithoutSamples(SymbolID SymbolID);
 
-  /// Returns a iterable StringRef for strings in the order they are added.
+  /// Returns an iterable StringRef for strings in the order they are added.
+  /// Each string may be a symbol name or a file name.
   auto getStrings() const {
     ArrayRef<std::pair<StringRef, uint64_t>> RefSymbolNames(
         StrToIndexMap.begin(), StrToIndexMap.end());
     return llvm::make_first_range(RefSymbolNames);
   }
 
   /// Returns array reference for various internal data structures.
-  inline ArrayRef<
+  ArrayRef<
       std::pair<std::variant<StringRef, uint64_t>, DataAccessProfRecord>>
   getRecords() const {
     return Records.getArrayRef();
   }
-  inline ArrayRef<StringRef> getKnownColdSymbols() const {
+  ArrayRef<StringRef> getKnownColdSymbols() const {
     return KnownColdSymbols.getArrayRef();
   }
-  inline ArrayRef<uint64_t> getKnownColdHashes() const {
+  ArrayRef<uint64_t> getKnownColdHashes() const {
     return KnownColdHashes.getArrayRef();
   }
 

llvm/include/llvm/ProfileData/InstrProf.h

@@ -357,7 +357,7 @@ void createPGONameMetadata(GlobalObject &GO, StringRef PGOName);
 /// the duplicated profile variables for Comdat functions.
 bool needsComdatForCounter(const GlobalObject &GV, const Module &M);
 
-/// \c NameStrings is a string composed of one of more possibly encoded
+/// \c NameStrings is a string composed of one or more possibly encoded
 /// sub-strings. The substrings are separated by 0 or more zero bytes. This
 /// method decodes the string and calls `NameCallback` for each substring.
 Error readAndDecodeStrings(StringRef NameStrings,

llvm/lib/ProfileData/DataAccessProf.cpp

@@ -141,7 +141,7 @@ Error DataAccessProfData::serializeSymbolsAndFilenames(ProfOStream &OS) const {
   // Record the length of compressed string.
   OS.write(CompressedStringLen);
   // Write the chars in compressed strings.
-  for (auto &c : CompressedStrings)
+  for (char C : CompressedStrings)
     OS.writeByte(static_cast<uint8_t>(c));
   // Pad up to a multiple of 8.
   // InstrProfReader could read bytes according to 'CompressedStringLen'.