Adopt @winner245's review comments on comments

frederick-vs-ja · frederick-vs-ja · commit 803d52f5eff3 · 2025-02-20T10:31:39.000+08:00
diff --git a/libcxx/include/__vector/vector.h b/libcxx/include/__vector/vector.h
@@ -618,7 +618,7 @@ class _LIBCPP_TEMPLATE_VIS vector {
   _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI void
   __insert_assign_n_unchecked(_Iterator __first, difference_type __n, pointer __position) {
 #if _LIBCPP_STD_VER >= 23
-    if constexpr (!forward_iterator<_Iterator>) {
+    if constexpr (!forward_iterator<_Iterator>) { // Handles input-only sized ranges for insert_range
       ranges::copy_n(std::move(__first), __n, __position);
     } else
 #endif
diff --git a/libcxx/test/std/containers/sequences/vector/vector.modifiers/insert_iter_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/vector/vector.modifiers/insert_iter_iter_iter.pass.cpp
@@ -163,7 +163,7 @@ TEST_CONSTEXPR_CXX20 bool tests() {
     for (; j < 105; ++j)
       assert(v[j] == 0);
   }
-  {
+  { // Ensure that iterator-pair insert() doesn't use unexpected assignment.
     struct Wrapper {
       TEST_CONSTEXPR Wrapper(int n) : n_(n) {}
 

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ TEST_CONSTEXPR_CXX20 bool tests() {`
`163`	`163`	`for (; j < 105; ++j)`
`164`	`164`	`assert(v[j] == 0);`
`165`	`165`	`}`
`166`		`- {`
	`166`	`+ { // Ensure that iterator-pair insert() doesn't use unexpected assignment.`
`167`	`167`	`struct Wrapper {`
`168`	`168`	`TEST_CONSTEXPR Wrapper(int n) : n_(n) {}`
`169`	`169`