renamed variable and const -> constexpr

Author: Sriya Pratipati

libc/src/__support/wchar/character_converter.cpp

@@ -38,7 +38,7 @@ int CharacterConverter::push(char8_t utf8_byte) {
     else if (numOnes >= 2 && numOnes <= 4) {
       /* Since the format is 110xxxxx, 1110xxxx, and 11110xxx for 2, 3, and 4,
       we will make the base mask with 7 ones and right shift it as necessary. */
-      const size_t significant_bits = 7;
+      constexpr size_t significant_bits = 7;
       state->total_bytes = numOnes;
       utf8_byte &=
           (mask_trailing_ones<uint32_t, significant_bits>() >> numOnes);
@@ -53,10 +53,10 @@ int CharacterConverter::push(char8_t utf8_byte) {
   }
   // Any subsequent push
   // Adding 6 more bits so need to left shift
-  const size_t BITS_PER_UTF8 = 6;
+  constexpr size_t ENCODED_BITS_PER_UTF8 = 6;
   if (cpp::countl_one(utf8_byte) == 1 && !isComplete()) {
-    char32_t byte = utf8_byte & mask_trailing_ones<uint32_t, BITS_PER_UTF8>();
-    state->partial = state->partial << BITS_PER_UTF8;
+    char32_t byte = utf8_byte & mask_trailing_ones<uint32_t, ENCODED_BITS_PER_UTF8>();
+    state->partial = state->partial << ENCODED_BITS_PER_UTF8;
     state->partial |= byte;
     state->bytes_processed++;
     return 0;