Address Review Comments

Author: easyonaadit

llvm/include/llvm/IR/IntrinsicsAMDGPU.td

@@ -2342,14 +2342,16 @@ class AMDGPUWaveReduce<LLVMType data_ty = llvm_anyint_ty> : Intrinsic<
     ],
     [IntrNoMem, IntrConvergent, IntrWillReturn, IntrNoCallback, IntrNoFree, ImmArg<ArgIndex<1>>]>;
 
-multiclass AMDGPUWaveReduceOps<list<string> Operations> {
-  foreach Op = Operations in { def Op : AMDGPUWaveReduce; }
+multiclass AMDGPUWaveReduceOps {
+  foreach Op = [
+    "umin", "min", "umax", "max", "uadd", "add", "usub", "sub", "and", "or",
+    "xor"
+  ] in {
+    def Op : AMDGPUWaveReduce;
+  }
 }
 
-defvar Operations = [
-  "umin", "min", "umax", "max", "uadd", "add", "usub", "sub", "and", "or", "xor"
-];
-defm int_amdgcn_wave_reduce_ : AMDGPUWaveReduceOps<Operations>;
+defm int_amdgcn_wave_reduce_ : AMDGPUWaveReduceOps;
 
 def int_amdgcn_readfirstlane :
   Intrinsic<[llvm_any_ty], [LLVMMatchType<0>],

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

@@ -5182,7 +5182,7 @@ static MachineBasicBlock *lowerWaveReduce(MachineInstr &MI,
     unsigned MovOpc = IsWave32 ? AMDGPU::S_MOV_B32 : AMDGPU::S_MOV_B64;
     unsigned ExecReg = IsWave32 ? AMDGPU::EXEC_LO : AMDGPU::EXEC;
 
-    // Create initail values of induction variable from Exec, Accumulator and
+    // Create initial values of induction variable from Exec, Accumulator and
     // insert branch instr to newly created ComputeBlock
     uint32_t InitalValue = getIdentityValueForWaveReduction(Opc);
     auto TmpSReg =