Skip to content

Commit 8121680

Browse files
committed
Address comments
1 parent 9ba9d44 commit 8121680

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1295,7 +1295,8 @@ func.func @extract_scalar_from_vec_2d_f32_inner_dynamic_idx(%arg0: vector<1x16xf
12951295
return %0 : f32
12961296
}
12971297

1298-
// Multi-dim vectors are supported if the innermost index is dynamic.
1298+
// Lowering supports extracting from multi-dim vectors with dynamic indices
1299+
// provided that only the trailing index is dynamic.
12991300

13001301
// CHECK-LABEL: @extract_scalar_from_vec_2d_f32_inner_dynamic_idx(
13011302
// CHECK: llvm.extractvalue
@@ -1306,7 +1307,8 @@ func.func @extract_scalar_from_vec_2d_f32_inner_dynamic_idx_scalable(%arg0: vect
13061307
return %0 : f32
13071308
}
13081309

1309-
// Multi-dim vectors are supported if the innermost index is dynamic.
1310+
// Lowering supports extracting from multi-dim vectors with dynamic indices
1311+
// provided that only the trailing index is dynamic.
13101312

13111313
// CHECK-LABEL: @extract_scalar_from_vec_2d_f32_inner_dynamic_idx_scalable(
13121314
// CHECK: llvm.extractvalue
@@ -1319,7 +1321,8 @@ func.func @extract_scalar_from_vec_2d_f32_outer_dynamic_idx(%arg0: vector<1x16xf
13191321
return %0 : f32
13201322
}
13211323

1322-
// Multi-dim vectors are supported if the inner most dimension is dynamic.
1324+
// Lowering supports extracting from multi-dim vectors with dynamic indices
1325+
// provided that only the trailing index is dynamic.
13231326

13241327
// CHECK-LABEL: @extract_scalar_from_vec_2d_f32_outer_dynamic_idx(
13251328
// CHECK: vector.extract
@@ -1329,8 +1332,8 @@ func.func @extract_scalar_from_vec_2d_f32_outer_dynamic_idx_scalable(%arg0: vect
13291332
return %0 : f32
13301333
}
13311334

1332-
// Multi-dim vectors with outer indices as dynamic are not supported, but it
1333-
// shouldn't crash.
1335+
// Lowering does not support extracting from multi-dim vectors with non trailing
1336+
// dynamic index, but it shouldn't crash.
13341337

13351338
// CHECK-LABEL: @extract_scalar_from_vec_2d_f32_outer_dynamic_idx_scalable(
13361339
// CHECK: vector.extract

0 commit comments

Comments
 (0)