@@ -144,10 +144,9 @@ size_t ObjectFileXCOFF::GetModuleSpecifications(
144144
145145static uint32_t XCOFFHeaderSizeFromMagic (uint32_t magic) {
146146 switch (magic) {
147- // TODO: 32bit not supported yet
147+ // TODO: 32bit not supported.
148148 // case XCOFF::XCOFF32:
149149 // return sizeof(struct llvm::object::XCOFFFileHeader32);
150-
151150 case XCOFF::XCOFF64:
152151 return sizeof (struct llvm ::object::XCOFFFileHeader64);
153152 break ;
@@ -163,7 +162,6 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP &data_sp,
163162 lldb::addr_t data_length) {
164163 lldb_private::DataExtractor data;
165164 data.SetData (data_sp, data_offset, data_length);
166-
167165 // Need to set this as XCOFF is only compatible with Big Endian
168166 data.SetByteOrder (eByteOrderBig);
169167 lldb::offset_t offset = 0 ;
@@ -172,26 +170,17 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP &data_sp,
172170}
173171
174172bool ObjectFileXCOFF::ParseHeader () {
175-
176- bool retVal = false ;
177173 ModuleSP module_sp (GetModule ());
178- if (module_sp) {
179- // Only 64-bit is supported for now
180- if (m_binary->fileHeader64 ()->Magic == XCOFF::XCOFF64)
181- retVal = true ;
182- }
183-
184- return retVal;
174+ // Only 64-bit is supported for now
175+ return module_sp && m_binary->fileHeader64 ()->Magic == XCOFF::XCOFF64;
185176}
186177
187178ByteOrder ObjectFileXCOFF::GetByteOrder () const { return eByteOrderBig; }
188179
189180bool ObjectFileXCOFF::IsExecutable () const { return true ; }
190181
191182uint32_t ObjectFileXCOFF::GetAddressByteSize () const {
192-
193- /* TODO: Need to handle 32-bit support, until then
194- * return 8 for 64-bit XCOFF::XCOFF64 */
183+ // 32-bit not supported. return 8 for 64-bit XCOFF::XCOFF64
195184 return 8 ;
196185}
197186
0 commit comments