[diagtool] Make the BuiltinDiagnosticsByID table sorted

Renamed DiagnosticIDs.inc to AllDiagnosticKinds.inc
Minor changes in comments.

Author: karka228

clang/include/clang/Basic/DiagnosticIDs.inc renamed to clang/include/clang/Basic/AllDiagnosticKinds.inc

@@ -1,4 +1,4 @@
-//===--- DiagnosticIDs.inc --------------------------------------*- C++ -*-===//
+//===--- AllDiagnosticKinds.inc----------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -7,12 +7,14 @@
 //===----------------------------------------------------------------------===//
 ///
 /// \file
-/// Defines the Diagnostic IDs in ID sorted order.
+/// Defines the Diagnostic IDs in ID sorted order. The order is dictated by
+/// the enum in DiagnosticIDs.h#L49-L65.
 ///
 //===----------------------------------------------------------------------===//
 
 // Turn off clang-format, as the order of the includes are important to make
-// sure the table is sorted.
+// sure tables based on Diagnostic IDs are partitioned/sorted based on
+// DiagID.
 
 // clang-format off
 #include "clang/Basic/DiagnosticCommonKinds.inc"

clang/lib/Basic/DiagnosticIDs.cpp

@@ -37,15 +37,15 @@ struct StaticDiagInfoDescriptionStringTable {
 #define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR,     \
              SHOWINSYSHEADER, SHOWINSYSMACRO, DEFERRABLE, CATEGORY)            \
   char ENUM##_desc[sizeof(DESC)];
-#include "clang/Basic/DiagnosticIDs.inc"
+#include "clang/Basic/AllDiagnosticKinds.inc"
 #undef DIAG
 };
 
 const StaticDiagInfoDescriptionStringTable StaticDiagInfoDescriptions = {
 #define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR,     \
              SHOWINSYSHEADER, SHOWINSYSMACRO, DEFERRABLE, CATEGORY)            \
   DESC,
-#include "clang/Basic/DiagnosticIDs.inc"
+#include "clang/Basic/AllDiagnosticKinds.inc"
 #undef DIAG
 };
 
@@ -57,7 +57,7 @@ const uint32_t StaticDiagInfoDescriptionOffsets[] = {
 #define DIAG(ENUM, CLASS, DEFAULT_SEVERITY, DESC, GROUP, SFINAE, NOWERROR,     \
              SHOWINSYSHEADER, SHOWINSYSMACRO, DEFERRABLE, CATEGORY)            \
   offsetof(StaticDiagInfoDescriptionStringTable, ENUM##_desc),
-#include "clang/Basic/DiagnosticIDs.inc"
+#include "clang/Basic/AllDiagnosticKinds.inc"
 #undef DIAG
 };
 

clang/tools/diagtool/DiagnosticNames.cpp

@@ -29,7 +29,7 @@ static const DiagnosticRecord BuiltinDiagnosticsByID[] = {
 #define DIAG(ENUM, CLASS, DEFAULT_MAPPING, DESC, GROUP, SFINAE, NOWERROR,      \
              SHOWINSYSHEADER, SHOWINSYSMACRO, DEFER, CATEGORY)                 \
   {#ENUM, diag::ENUM, STR_SIZE(#ENUM, uint8_t)},
-#include "clang/Basic/DiagnosticIDs.inc"
+#include "clang/Basic/AllDiagnosticKinds.inc"
 #undef DIAG
 };