Skip to content

Commit 81b0b1d

Browse files
mark-sedMarek Sedlacek
authored andcommitted
[LoopRotate] Remove canRotateDeoptimizingLatchExit and multi-rotate (#162482)
This patch removes canRotateDeoptimizingLatchExit check from loop roate and connected multi rotation option for loop roate (-loop-rotate-multi option). The heuristic in canRotateDeoptimizingLatchExit returns true if any of the loop exits are non-deoptimizing. This means if the loop has multiple deopt exits, then without multi-rotate, we may still end up having deopt exit at the latch. This multi-rotate option is introduced but it is off by default. We have not seen any improvements downstream as well, where we have frequent number of deoptimizations in IR. Since the original heuristic without the multi-rotate effectively ends up being "rotate under some conditions", but the loop may still not be in the form we want, we should remove the heuristic and multi-rotate framework entirely Note that the diff is big, but it's just removal of while loop and indentation change. After this patch I would like to continue here and propose adding a computability check for exit count, but that will be in a separate PR. Requests for review: @annamthomas @fhahn @davemgreen Co-authored-by: Marek Sedlacek <[email protected]>
1 parent 317e4e3 commit 81b0b1d

File tree

3 files changed

+436
-903
lines changed

3 files changed

+436
-903
lines changed

0 commit comments

Comments
 (0)