Skip to content

Commit 8233fed

Browse files
committed
Revert libclang-python-tests.yml changes.
Reintroduce check-clang-python.
1 parent 6c3878f commit 8233fed

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

.github/workflows/libclang-python-tests.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ on:
1010
- 'main'
1111
paths:
1212
- 'clang/bindings/python/**'
13-
- 'clang/test/bindings/python/**'
1413
- 'clang/tools/libclang/**'
14+
- 'clang/CMakeList.txt'
1515
- '.github/workflows/libclang-python-tests.yml'
1616
- '.github/workflows/llvm-project-tests.yml'
1717
pull_request:
1818
paths:
1919
- 'clang/bindings/python/**'
20-
- 'clang/test/bindings/python/**'
2120
- 'clang/tools/libclang/**'
21+
- 'clang/CMakeList.txt'
2222
- '.github/workflows/libclang-python-tests.yml'
2323
- '.github/workflows/llvm-project-tests.yml'
2424

@@ -33,9 +33,7 @@ jobs:
3333
python-version: ["3.8", "3.13"]
3434
uses: ./.github/workflows/llvm-project-tests.yml
3535
with:
36-
build_target: libclang
37-
run: |
38-
llvm-lit -v tools/clang/test --filter=bindings.sh
36+
build_target: check-clang-python
3937
projects: clang
4038
# There is an issue running on "windows-2019".
4139
# See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.

clang/test/CMakeLists.txt

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,17 @@ add_custom_target(clang-test)
205205
add_dependencies(clang-test check-clang)
206206
set_target_properties(clang-test PROPERTIES FOLDER "Clang/Tests")
207207

208+
# Allow running Clang Python binding tests separately from CI.
209+
add_lit_testsuite(check-clang-python "Running the Clang Python tests"
210+
${CMAKE_CURRENT_BINARY_DIR}
211+
#LIT ${LLVM_LIT}
212+
PARAMS ${CLANG_TEST_PARAMS}
213+
DEPENDS ${CLANG_TEST_DEPS}
214+
ARGS ${CLANG_TEST_EXTRA_ARGS} --filter=bindings.sh
215+
# Avoid running tests twice.
216+
EXCLUDE_FROM_CHECK_ALL
217+
)
218+
208219
# FIXME: This logic can be removed once all buildbots have moved
209220
# debuginfo-test from clang/test to llvm/projects or monorepo.
210221
if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/debuginfo-tests)

0 commit comments

Comments
 (0)