Address feedback: use proper symbolic value for test4

marco-antognini-sonarsource · marco-antognini-sonarsource · commit 82a7fc6957ab · 2025-10-01T17:11:21.000+02:00
diff --git a/clang/test/Analysis/initializer.cpp b/clang/test/Analysis/initializer.cpp
@@ -644,10 +644,10 @@ void test3() {
   clang_analyzer_eval(*a.m_ptr == 0); // expected-warning{{TRUE}}
 }
 
-void test4() {
-  A a(0, 314);
-  clang_analyzer_eval(a.m_buf[0] == 0); // expected-warning{{TRUE}}
-  clang_analyzer_eval(*a.m_ptr == 0); // expected-warning{{TRUE}}
+void test4(char arg) {
+  A a(arg, 314);
+  clang_analyzer_eval(a.m_buf[0] == arg); // expected-warning{{TRUE}}
+  clang_analyzer_eval(*a.m_ptr == arg); // expected-warning{{TRUE}}
 }
 
 } // namespace gh147686

Original file line number	Diff line number	Diff line change
`@@ -644,10 +644,10 @@ void test3() {`
`644`	`644`	`clang_analyzer_eval(*a.m_ptr == 0); // expected-warning{{TRUE}}`
`645`	`645`	`}`
`646`	`646`
`647`		`-void test4() {`
`648`		`- A a(0, 314);`
`649`		`- clang_analyzer_eval(a.m_buf[0] == 0); // expected-warning{{TRUE}}`
`650`		`- clang_analyzer_eval(*a.m_ptr == 0); // expected-warning{{TRUE}}`
	`647`	`+void test4(char arg) {`
	`648`	`+ A a(arg, 314);`
	`649`	`+ clang_analyzer_eval(a.m_buf[0] == arg); // expected-warning{{TRUE}}`
	`650`	`+ clang_analyzer_eval(*a.m_ptr == arg); // expected-warning{{TRUE}}`
`651`	`651`	`}`
`652`	`652`
`653`	`653`	`} // namespace gh147686`