Apply suggestion from @frederick-vs-ja

c8ef · frederick-vs-ja · web-flow · commit 82bb2ee5cb3f · 2025-10-18T20:41:21.000+08:00
Co-authored-by: A. Jiang &lt;de34@live.cn&gt;
diff --git a/libcxx/include/__algorithm/generate.h b/libcxx/include/__algorithm/generate.h
@@ -22,7 +22,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD
 template <class _ForwardIterator, class _Generator>
 inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void
 generate(_ForwardIterator __first, _ForwardIterator __last, _Generator __gen) {
-  std::for_each(__first, __last, [&](decltype(*__first) __element) { __element = __gen(); });
+  using __iter_ref = decltype(*__first);
+  std::for_each(__first, __last, [&](__iter_ref __element) { std::forward<__iter_ref>(__element) = __gen(); });
 }
 
 _LIBCPP_END_NAMESPACE_STD

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@ _LIBCPP_BEGIN_NAMESPACE_STD`
`22`	`22`	`template <class _ForwardIterator, class _Generator>`
`23`	`23`	`inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void`
`24`	`24`	`generate(_ForwardIterator __first, _ForwardIterator __last, _Generator __gen) {`
`25`		`- std::for_each(__first, __last, [&](decltype(*__first) __element) { __element = __gen(); });`
	`25`	`+ using __iter_ref = decltype(*__first);`
	`26`	`+ std::for_each(__first, __last, [&](__iter_ref __element) { std::forward<__iter_ref>(__element) = __gen(); });`
`26`	`27`	`}`
`27`	`28`
`28`	`29`	`_LIBCPP_END_NAMESPACE_STD`