Skip to content

Commit 82c9849

Browse files
committed
Address review comments
1 parent f7aba99 commit 82c9849

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

llvm/unittests/Analysis/MemoryProfileInfoTest.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,10 +507,11 @@ declare dso_local noalias noundef i8* @malloc(i64 noundef)
507507
// the first in sorted order).
508508
Trie.addCallStack(AllocationType::NotCold, {1, 2, 3, 8, 9, 15});
509509

510-
// Neither of these two NotCold contexts are needed as the Cold contexts they
510+
// None of these NotCold contexts are needed as the Cold contexts they
511511
// overlap with are covered by longer overlapping NotCold contexts.
512512
Trie.addCallStack(AllocationType::NotCold, {1, 2, 3, 12});
513513
Trie.addCallStack(AllocationType::NotCold, {1, 2, 11});
514+
Trie.addCallStack(AllocationType::NotCold, {1, 16});
514515

515516
std::vector<std::pair<AllocationType, std::vector<unsigned>>> ExpectedVals = {
516517
{AllocationType::Cold, {1, 2, 3, 4}},
@@ -520,6 +521,7 @@ declare dso_local noalias noundef i8* @malloc(i64 noundef)
520521
{AllocationType::NotCold, {1, 2, 3, 8, 9, 14}}};
521522

522523
CallBase *Call = findCall(*Func, "call");
524+
ASSERT_NE(Call, nullptr);
523525
Trie.buildAndAttachMIBMetadata(Call);
524526

525527
EXPECT_FALSE(Call->hasFnAttr("memprof"));

0 commit comments

Comments
 (0)