Skip to content

Commit 82ed76a

Browse files
committed
Add comment explaining if and add a test
1 parent 12ff645 commit 82ed76a

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

lldb/include/lldb/Core/DebuggerEvents.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class ProgressEventData : public EventData {
4444
uint64_t GetCompleted() const { return m_completed; }
4545
uint64_t GetTotal() const { return m_total; }
4646
std::string GetMessage() const {
47+
// Only put the title in the message of the progress create event.
4748
if (m_completed == 0) {
4849
std::string message = m_title;
4950
if (!m_details.empty()) {

lldb/test/API/tools/lldb-dap/progress/TestDAP_Progress.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,13 @@ def test_output(self):
4141
for event in self.dap_server.progress_events:
4242
event_type = event["event"]
4343
if "progressStart" in event_type:
44+
title = event["body"]["title"]
45+
self.assertIn("Progress tester", title)
4446
start_found = True
4547
if "progressUpdate" in event_type:
48+
message = event["body"]["message"]
49+
print(f"Progress update: {message}")
50+
self.assertNotIn("Progres tester", message)
4651
update_found = True
4752

4853
self.assertTrue(start_found)

0 commit comments

Comments
 (0)