Skip to content

Commit 83138cc

Browse files
committed
Address comments
1 parent 2440ca6 commit 83138cc

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -653,6 +653,9 @@ struct PadTilingInterfaceResult {
653653
// interpreted as the bounding box (dynamic) value to pad to.
654654
/// * Use "options.paddingValues" to set the padding value of the created
655655
// tensor::PadOp.
656+
//
657+
// The transformation assumes that the insertion point is set after the
658+
// operation to pad.
656659
FailureOr<PadTilingInterfaceResult>
657660
rewriteAsPaddedOp(OpBuilder &, TilingInterface toPad,
658661
PadTilingInterfaceOptions options,

mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2464,6 +2464,8 @@ transform::PadTilingInterfaceOp::apply(transform::TransformRewriter &rewriter,
24642464
.setPaddingSizes(getMixedPaddingSizes())
24652465
.setPadToMultipleOf(getPadToMultipleOf());
24662466

2467+
OpBuilder::InsertionGuard g(rewriter);
2468+
rewriter.setInsertionPointAfter(targetOp);
24672469
auto maybePadOps = rewriteAsPaddedOp(
24682470
rewriter, cast<TilingInterface>(targetOp.getOperation()), options);
24692471
if (failed(maybePadOps)) {

0 commit comments

Comments
 (0)