Address review feedback

Author: Il-Capitano

llvm/include/llvm/BinaryFormat/ELF.h

@@ -1299,7 +1299,7 @@ enum : unsigned {
   // Section data is string data by default.
   SHF_MIPS_STRING = 0x80000000,
 
-  // Make code section unreadable when in execute-only mode
+  // Section contains only program instructions and no program data.
   SHF_ARM_PURECODE = 0x20000000,
 
   // Section contains only program instructions and no program data.

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

@@ -559,11 +559,12 @@ static unsigned getELFSectionFlags(SectionKind K, const Triple &T) {
   if (K.isText())
     Flags |= ELF::SHF_EXECINSTR;
 
-  if ((T.isARM() || T.isThumb()) && K.isExecuteOnly())
-    Flags |= ELF::SHF_ARM_PURECODE;
-
-  if (T.isAArch64() && K.isExecuteOnly())
-    Flags |= ELF::SHF_AARCH64_PURECODE;
+  if (K.isExecuteOnly()) {
+    if (T.isAArch64())
+      Flags |= ELF::SHF_AARCH64_PURECODE;
+    else if (T.isARM() || T.isThumb())
+      Flags |= ELF::SHF_ARM_PURECODE;
+  }
 
   if (K.isWriteable())
     Flags |= ELF::SHF_WRITE;

llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp

@@ -295,7 +295,8 @@ bool AArch64TTIImpl::areInlineCompatible(const Function *Caller,
       TM.getSubtargetImpl(*Callee)->getFeatureBits();
   // Adjust the feature bitsets by inverting some of the bits. This is needed
   // for target features that represent restrictions rather than capabilities,
-  // for example "+execute-only".
+  // for example a "+execute-only" callee can be inlined into a caller without
+  // "+execute-only", but not vice versa.
   FeatureBitset EffectiveCallerBits = CallerBits ^ InlineInverseFeatures;
   FeatureBitset EffectiveCalleeBits = CalleeBits ^ InlineInverseFeatures;