[mlir] Fix possible null dereference during error logging

apach301 · apach301 · commit 835c45e1ef65 · 2025-09-08T16:19:53.000+03:00
diff --git a/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp b/mlir/lib/Conversion/MPIToLLVM/MPIToLLVM.cpp
@@ -405,7 +405,8 @@ std::unique_ptr<MPIImplTraits> MPIImplTraits::get(ModuleOp &moduleOp) {
     return std::make_unique<OMPIImplTraits>(moduleOp);
   if (!strAttr || strAttr.getValue() != "MPICH")
     moduleOp.emitWarning() << "Unknown \"MPI:Implementation\" value in DLTI ("
-                           << strAttr.getValue() << "), defaulting to MPICH";
+                           << (strAttr ? strAttr.getValue() : "<NULL>")
+                           << "), defaulting to MPICH";
   return std::make_unique<MPICHImplTraits>(moduleOp);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -405,7 +405,8 @@ std::unique_ptr<MPIImplTraits> MPIImplTraits::get(ModuleOp &moduleOp) {`
`405`	`405`	`return std::make_unique<OMPIImplTraits>(moduleOp);`
`406`	`406`	`if (!strAttr \|\| strAttr.getValue() != "MPICH")`
`407`	`407`	`moduleOp.emitWarning() << "Unknown \"MPI:Implementation\" value in DLTI ("`
`408`		`- << strAttr.getValue() << "), defaulting to MPICH";`
	`408`	`+ << (strAttr ? strAttr.getValue() : "<NULL>")`
	`409`	`+ << "), defaulting to MPICH";`
`409`	`410`	`return std::make_unique<MPICHImplTraits>(moduleOp);`
`410`	`411`	`}`
`411`	`412`