Skip to content

Commit 83c68c8

Browse files
committed
[InstCombine] Fold (A | B) ^ (A & C) --> A ? ~C : B
1 parent d0680ff commit 83c68c8

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4972,8 +4972,8 @@ Instruction *InstCombinerImpl::visitXor(BinaryOperator &I) {
49724972

49734973
// (A & B) ^ (A | C) --> A ? ~B : C -- There are 4 commuted variants.
49744974
if (I.getType()->isIntOrIntVectorTy(1) &&
4975-
match(Op0, m_OneUse(m_LogicalAnd(m_Value(A), m_Value(B)))) &&
4976-
match(Op1, m_OneUse(m_LogicalOr(m_Value(C), m_Value(D))))) {
4975+
match(&I, m_c_Xor(m_OneUse(m_LogicalAnd(m_Value(A), m_Value(B))),
4976+
m_OneUse(m_LogicalOr(m_Value(C), m_Value(D)))))) {
49774977
bool NeedFreeze = isa<SelectInst>(Op0) && isa<SelectInst>(Op1) && B == D;
49784978
if (B == C || B == D)
49794979
std::swap(A, B);

llvm/test/Transforms/InstCombine/xor-and-or.ll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@ define i1 @xor_logic_and_logic_or2(i1 %c, i1 %x, i1 %y) {
2727

2828
define i1 @xor_logic_and_logic_or2_commuted(i1 %c, i1 %x, i1 %y) {
2929
; CHECK-LABEL: @xor_logic_and_logic_or2_commuted(
30-
; CHECK-NEXT: [[O:%.*]] = select i1 [[Y:%.*]], i1 true, i1 [[C:%.*]]
31-
; CHECK-NEXT: [[A:%.*]] = select i1 [[C]], i1 [[X:%.*]], i1 false
32-
; CHECK-NEXT: [[R:%.*]] = xor i1 [[O]], [[A]]
30+
; CHECK-NEXT: [[TMP1:%.*]] = xor i1 [[X:%.*]], true
31+
; CHECK-NEXT: [[R:%.*]] = select i1 [[C:%.*]], i1 [[TMP1]], i1 [[Y:%.*]]
3332
; CHECK-NEXT: ret i1 [[R]]
3433
;
3534
%o = select i1 %y, i1 true, i1 %c

0 commit comments

Comments
 (0)