Skip to content

Commit 83cb8b7

Browse files
[llvm] Use a range-based for loop instead of {std,llvm}::for_each (NFC) (#150841)
LLVM Coding Standards discourages {std,llvm}::for_each unless we already have a callable.
1 parent 5deb442 commit 83cb8b7

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

llvm/lib/Target/RISCV/RISCVFrameLowering.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1581,7 +1581,8 @@ void RISCVFrameLowering::determineCalleeSaves(MachineFunction &MF,
15811581
// Set the register and all its subregisters.
15821582
if (!MRI.def_empty(CSReg) || MRI.getUsedPhysRegsMask().test(CSReg)) {
15831583
SavedRegs.set(CSReg);
1584-
llvm::for_each(SubRegs, [&](unsigned Reg) { return SavedRegs.set(Reg); });
1584+
for (unsigned Reg : SubRegs)
1585+
SavedRegs.set(Reg);
15851586
}
15861587

15871588
// Combine to super register if all of its subregisters are marked.

llvm/lib/TargetParser/RISCVISAInfo.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -858,16 +858,15 @@ void RISCVISAInfo::updateImplication() {
858858
StringRef ExtName = WorkList.pop_back_val();
859859
auto Range = std::equal_range(std::begin(ImpliedExts),
860860
std::end(ImpliedExts), ExtName);
861-
std::for_each(Range.first, Range.second,
862-
[&](const ImpliedExtsEntry &Implied) {
863-
const char *ImpliedExt = Implied.ImpliedExt;
864-
auto [It, Inserted] = Exts.try_emplace(ImpliedExt);
865-
if (!Inserted)
866-
return;
867-
auto Version = findDefaultVersion(ImpliedExt);
868-
It->second = *Version;
869-
WorkList.push_back(ImpliedExt);
870-
});
861+
for (const ImpliedExtsEntry &Implied : llvm::make_range(Range)) {
862+
const char *ImpliedExt = Implied.ImpliedExt;
863+
auto [It, Inserted] = Exts.try_emplace(ImpliedExt);
864+
if (!Inserted)
865+
continue;
866+
auto Version = findDefaultVersion(ImpliedExt);
867+
It->second = *Version;
868+
WorkList.push_back(ImpliedExt);
869+
}
871870
}
872871

873872
// Add Zcd if C and D are enabled.

0 commit comments

Comments
 (0)