[profile] runtime counter relocation is needed on windows-msvc targets

Wael Yehia · Wael Yehia · commit 843f78e9826b · 2025-02-19T18:41:38.000Z
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -795,7 +795,7 @@ static void addPGOAndCoverageFlags(const ToolChain &TC, Compilation &C,
     else {
       CmdArgs.push_back("-fprofile-continuous");
       // Platforms that require a bias variable:
-      if (T.isOSBinFormatELF() || T.isOSAIX()) {
+      if (T.isOSBinFormatELF() || T.isOSAIX() || T.isKnownWindowsMSVCEnvironment()) {
         CmdArgs.push_back("-mllvm");
         CmdArgs.push_back("-runtime-counter-relocation");
       }
diff --git a/clang/test/Driver/fprofile-continuous.c b/clang/test/Driver/fprofile-continuous.c
@@ -6,6 +6,7 @@
 
 // RUN: %clang --target=powerpc64-ibm-aix -fprofile-generate -fprofile-continuous -### -c %s 2>&1 | FileCheck %s --check-prefix=RELOC
 // RUN: %clang --target=x86_64-unknown-fuchsia -fprofile-generate -fprofile-continuous -### -c %s 2>&1 | FileCheck %s --check-prefix=RELOC
+// RUN: %clang --target=x86_64-windows-msvc -fprofile-generate -fprofile-continuous -### -c %s 2>&1 | FileCheck %s --check-prefix=RELOC
 // RELOC: "-cc1" {{.*}} "-fprofile-continuous" "-mllvm" "-runtime-counter-relocation"
 
 // 2) test -fprofile-continuous with cs-profile-generate and -fprofile-instr-generate

Original file line number	Diff line number	Diff line change
`@@ -795,7 +795,7 @@ static void addPGOAndCoverageFlags(const ToolChain &TC, Compilation &C,`
`795`	`795`	`else {`
`796`	`796`	`CmdArgs.push_back("-fprofile-continuous");`
`797`	`797`	`// Platforms that require a bias variable:`
`798`		`- if (T.isOSBinFormatELF() \|\| T.isOSAIX()) {`
	`798`	`+ if (T.isOSBinFormatELF() \|\| T.isOSAIX() \|\| T.isKnownWindowsMSVCEnvironment()) {`
`799`	`799`	`CmdArgs.push_back("-mllvm");`
`800`	`800`	`CmdArgs.push_back("-runtime-counter-relocation");`
`801`	`801`	`}`