Skip to content

Commit 844a320

Browse files
fsb4000mordante
fsb4000
authored and
mordante
committed
Tests ignore the return value of sto{meow}, triggering nodiscard warnings in MS STL
Reviewed By: #libc, Mordante Differential Revision: https://reviews.llvm.org/D129925
1 parent d8888e1 commit 844a320

File tree

8 files changed

+58
-58
lines changed

8 files changed

+58
-58
lines changed

‎libcxx/test/std/strings/string.conversions/stod.pass.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ int main(int, char**)
6060
{
6161
size_t idx = 0;
6262
try {
63-
std::stod("", &idx);
63+
(void)std::stod("", &idx);
6464
assert(false);
6565
} catch (const std::invalid_argument&) {
6666
assert(idx == 0);
@@ -69,7 +69,7 @@ int main(int, char**)
6969
{
7070
size_t idx = 0;
7171
try {
72-
std::stod(" - 8", &idx);
72+
(void)std::stod(" - 8", &idx);
7373
assert(false);
7474
} catch (const std::invalid_argument&) {
7575
assert(idx == 0);
@@ -78,7 +78,7 @@ int main(int, char**)
7878
{
7979
size_t idx = 0;
8080
try {
81-
std::stod("a1", &idx);
81+
(void)std::stod("a1", &idx);
8282
assert(false);
8383
} catch (const std::invalid_argument&) {
8484
assert(idx == 0);
@@ -127,7 +127,7 @@ int main(int, char**)
127127
{
128128
size_t idx = 0;
129129
try {
130-
std::stod(L"", &idx);
130+
(void)std::stod(L"", &idx);
131131
assert(false);
132132
} catch (const std::invalid_argument&) {
133133
assert(idx == 0);
@@ -136,7 +136,7 @@ int main(int, char**)
136136
{
137137
size_t idx = 0;
138138
try {
139-
std::stod(L" - 8", &idx);
139+
(void)std::stod(L" - 8", &idx);
140140
assert(false);
141141
} catch (const std::invalid_argument&) {
142142
assert(idx == 0);
@@ -145,7 +145,7 @@ int main(int, char**)
145145
{
146146
size_t idx = 0;
147147
try {
148-
std::stod(L"a1", &idx);
148+
(void)std::stod(L"a1", &idx);
149149
assert(false);
150150
} catch (const std::invalid_argument&) {
151151
assert(idx == 0);

‎libcxx/test/std/strings/string.conversions/stof.pass.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ int main(int, char**)
6161
{
6262
size_t idx = 0;
6363
try {
64-
std::stof("", &idx);
64+
(void)std::stof("", &idx);
6565
assert(false);
6666
} catch (const std::invalid_argument&) {
6767
assert(idx == 0);
@@ -70,7 +70,7 @@ int main(int, char**)
7070
{
7171
size_t idx = 0;
7272
try {
73-
std::stof(" - 8", &idx);
73+
(void)std::stof(" - 8", &idx);
7474
assert(false);
7575
} catch (const std::invalid_argument&) {
7676
assert(idx == 0);
@@ -79,7 +79,7 @@ int main(int, char**)
7979
{
8080
size_t idx = 0;
8181
try {
82-
std::stof("a1", &idx);
82+
(void)std::stof("a1", &idx);
8383
assert(false);
8484
} catch (const std::invalid_argument&) {
8585
assert(idx == 0);
@@ -129,7 +129,7 @@ int main(int, char**)
129129
{
130130
size_t idx = 0;
131131
try {
132-
std::stof(L"", &idx);
132+
(void)std::stof(L"", &idx);
133133
assert(false);
134134
} catch (const std::invalid_argument&) {
135135
assert(idx == 0);
@@ -138,7 +138,7 @@ int main(int, char**)
138138
{
139139
size_t idx = 0;
140140
try {
141-
std::stof(L" - 8", &idx);
141+
(void)std::stof(L" - 8", &idx);
142142
assert(false);
143143
} catch (const std::invalid_argument&) {
144144
assert(idx == 0);
@@ -147,7 +147,7 @@ int main(int, char**)
147147
{
148148
size_t idx = 0;
149149
try {
150-
std::stof(L"a1", &idx);
150+
(void)std::stof(L"a1", &idx);
151151
assert(false);
152152
} catch (const std::invalid_argument&) {
153153
assert(idx == 0);

‎libcxx/test/std/strings/string.conversions/stoi.pass.cpp‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ int main(int, char**)
3232
if (std::numeric_limits<long>::max() > std::numeric_limits<int>::max()) {
3333
size_t idx = 0;
3434
try {
35-
std::stoi("0x100000000", &idx, 16);
35+
(void)std::stoi("0x100000000", &idx, 16);
3636
assert(false);
3737
} catch (const std::out_of_range&) {
3838

@@ -41,7 +41,7 @@ int main(int, char**)
4141
{
4242
size_t idx = 0;
4343
try {
44-
std::stoi("", &idx);
44+
(void)std::stoi("", &idx);
4545
assert(false);
4646
} catch (const std::invalid_argument&) {
4747
assert(idx == 0);
@@ -50,7 +50,7 @@ int main(int, char**)
5050
{
5151
size_t idx = 0;
5252
try {
53-
std::stoi(" - 8", &idx);
53+
(void)std::stoi(" - 8", &idx);
5454
assert(false);
5555
} catch (const std::invalid_argument&) {
5656
assert(idx == 0);
@@ -59,7 +59,7 @@ int main(int, char**)
5959
{
6060
size_t idx = 0;
6161
try {
62-
std::stoi("a1", &idx);
62+
(void)std::stoi("a1", &idx);
6363
assert(false);
6464
} catch (const std::invalid_argument&) {
6565
assert(idx == 0);
@@ -81,7 +81,7 @@ int main(int, char**)
8181
if (std::numeric_limits<long>::max() > std::numeric_limits<int>::max()) {
8282
size_t idx = 0;
8383
try {
84-
std::stoi(L"0x100000000", &idx, 16);
84+
(void)std::stoi(L"0x100000000", &idx, 16);
8585
assert(false);
8686
} catch (const std::out_of_range&) {
8787

@@ -90,7 +90,7 @@ int main(int, char**)
9090
{
9191
size_t idx = 0;
9292
try {
93-
std::stoi(L"", &idx);
93+
(void)std::stoi(L"", &idx);
9494
assert(false);
9595
} catch (const std::invalid_argument&) {
9696
assert(idx == 0);
@@ -99,7 +99,7 @@ int main(int, char**)
9999
{
100100
size_t idx = 0;
101101
try {
102-
std::stoi(L" - 8", &idx);
102+
(void)std::stoi(L" - 8", &idx);
103103
assert(false);
104104
} catch (const std::invalid_argument&) {
105105
assert(idx == 0);
@@ -108,7 +108,7 @@ int main(int, char**)
108108
{
109109
size_t idx = 0;
110110
try {
111-
std::stoi(L"a1", &idx);
111+
(void)std::stoi(L"a1", &idx);
112112
assert(false);
113113
} catch (const std::invalid_argument&) {
114114
assert(idx == 0);

‎libcxx/test/std/strings/string.conversions/stol.pass.cpp‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ int main(int, char**)
3232
{
3333
size_t idx = 0;
3434
try {
35-
std::stol("", &idx);
35+
(void)std::stol("", &idx);
3636
assert(false);
3737
} catch (const std::invalid_argument&) {
3838
assert(idx == 0);
@@ -41,7 +41,7 @@ int main(int, char**)
4141
{
4242
size_t idx = 0;
4343
try {
44-
std::stol(" - 8", &idx);
44+
(void)std::stol(" - 8", &idx);
4545
assert(false);
4646
} catch (const std::invalid_argument&) {
4747
assert(idx == 0);
@@ -50,7 +50,7 @@ int main(int, char**)
5050
{
5151
size_t idx = 0;
5252
try {
53-
std::stol("a1", &idx);
53+
(void)std::stol("a1", &idx);
5454
assert(false);
5555
} catch (const std::invalid_argument&) {
5656
assert(idx == 0);
@@ -60,7 +60,7 @@ int main(int, char**)
6060
size_t idx = 0;
6161
try {
6262
// LWG#2009 and PR14919
63-
std::stol("9999999999999999999999999999999999999999999999999", &idx);
63+
(void)std::stol("9999999999999999999999999999999999999999999999999", &idx);
6464
assert(false);
6565
} catch (const std::out_of_range&) {
6666
assert(idx == 0);
@@ -82,7 +82,7 @@ int main(int, char**)
8282
{
8383
size_t idx = 0;
8484
try {
85-
std::stol(L"", &idx);
85+
(void)std::stol(L"", &idx);
8686
assert(false);
8787
} catch (const std::invalid_argument&) {
8888
assert(idx == 0);
@@ -91,7 +91,7 @@ int main(int, char**)
9191
{
9292
size_t idx = 0;
9393
try {
94-
std::stol(L" - 8", &idx);
94+
(void)std::stol(L" - 8", &idx);
9595
assert(false);
9696
} catch (const std::invalid_argument&) {
9797
assert(idx == 0);
@@ -100,7 +100,7 @@ int main(int, char**)
100100
{
101101
size_t idx = 0;
102102
try {
103-
std::stol(L"a1", &idx);
103+
(void)std::stol(L"a1", &idx);
104104
assert(false);
105105
} catch (const std::invalid_argument&) {
106106
assert(idx == 0);
@@ -110,7 +110,7 @@ int main(int, char**)
110110
size_t idx = 0;
111111
try {
112112
// LWG#2009 and PR14919
113-
std::stol(L"9999999999999999999999999999999999999999999999999", &idx);
113+
(void)std::stol(L"9999999999999999999999999999999999999999999999999", &idx);
114114
assert(false);
115115
} catch (const std::out_of_range&) {
116116
assert(idx == 0);

‎libcxx/test/std/strings/string.conversions/stold.pass.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ int main(int, char**)
4949
{
5050
size_t idx = 0;
5151
try {
52-
std::stold("", &idx);
52+
(void)std::stold("", &idx);
5353
assert(false);
5454
} catch (const std::invalid_argument&) {
5555
assert(idx == 0);
@@ -58,7 +58,7 @@ int main(int, char**)
5858
{
5959
size_t idx = 0;
6060
try {
61-
std::stold(" - 8", &idx);
61+
(void)std::stold(" - 8", &idx);
6262
assert(false);
6363
} catch (const std::invalid_argument&) {
6464
assert(idx == 0);
@@ -67,7 +67,7 @@ int main(int, char**)
6767
{
6868
size_t idx = 0;
6969
try {
70-
std::stold("a1", &idx);
70+
(void)std::stold("a1", &idx);
7171
assert(false);
7272
} catch (const std::invalid_argument&) {
7373
assert(idx == 0);
@@ -113,7 +113,7 @@ int main(int, char**)
113113
{
114114
size_t idx = 0;
115115
try {
116-
std::stold(L"", &idx);
116+
(void)std::stold(L"", &idx);
117117
assert(false);
118118
} catch (const std::invalid_argument&) {
119119
assert(idx == 0);
@@ -122,7 +122,7 @@ int main(int, char**)
122122
{
123123
size_t idx = 0;
124124
try {
125-
std::stold(L" - 8", &idx);
125+
(void)std::stold(L" - 8", &idx);
126126
assert(false);
127127
} catch (const std::invalid_argument&) {
128128
assert(idx == 0);
@@ -131,7 +131,7 @@ int main(int, char**)
131131
{
132132
size_t idx = 0;
133133
try {
134-
std::stold(L"a1", &idx);
134+
(void)std::stold(L"a1", &idx);
135135
assert(false);
136136
} catch (const std::invalid_argument&) {
137137
assert(idx == 0);

‎libcxx/test/std/strings/string.conversions/stoll.pass.cpp‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ int main(int, char**)
3232
{
3333
size_t idx = 0;
3434
try {
35-
std::stoll("", &idx);
35+
(void)std::stoll("", &idx);
3636
assert(false);
3737
} catch (const std::invalid_argument&) {
3838
assert(idx == 0);
@@ -41,7 +41,7 @@ int main(int, char**)
4141
{
4242
size_t idx = 0;
4343
try {
44-
std::stoll(" - 8", &idx);
44+
(void)std::stoll(" - 8", &idx);
4545
assert(false);
4646
} catch (const std::invalid_argument&) {
4747
assert(idx == 0);
@@ -50,7 +50,7 @@ int main(int, char**)
5050
{
5151
size_t idx = 0;
5252
try {
53-
std::stoll("a1", &idx);
53+
(void)std::stoll("a1", &idx);
5454
assert(false);
5555
} catch (const std::invalid_argument&) {
5656
assert(idx == 0);
@@ -60,7 +60,7 @@ int main(int, char**)
6060
size_t idx = 0;
6161
try {
6262
// LWG#2009 and PR14919
63-
std::stoll("99999999999999999999999999", &idx);
63+
(void)std::stoll("99999999999999999999999999", &idx);
6464
assert(false);
6565
} catch (const std::out_of_range&) {
6666
assert(idx == 0);
@@ -82,7 +82,7 @@ int main(int, char**)
8282
{
8383
size_t idx = 0;
8484
try {
85-
std::stoll(L"", &idx);
85+
(void)std::stoll(L"", &idx);
8686
assert(false);
8787
} catch (const std::invalid_argument&) {
8888
assert(idx == 0);
@@ -91,7 +91,7 @@ int main(int, char**)
9191
{
9292
size_t idx = 0;
9393
try {
94-
std::stoll(L" - 8", &idx);
94+
(void)std::stoll(L" - 8", &idx);
9595
assert(false);
9696
} catch (const std::invalid_argument&) {
9797
assert(idx == 0);
@@ -100,7 +100,7 @@ int main(int, char**)
100100
{
101101
size_t idx = 0;
102102
try {
103-
std::stoll(L"a1", &idx);
103+
(void)std::stoll(L"a1", &idx);
104104
assert(false);
105105
} catch (const std::invalid_argument&) {
106106
assert(idx == 0);
@@ -110,7 +110,7 @@ int main(int, char**)
110110
size_t idx = 0;
111111
try {
112112
// LWG#2009 and PR14919
113-
std::stoll(L"99999999999999999999999999", &idx);
113+
(void)std::stoll(L"99999999999999999999999999", &idx);
114114
assert(false);
115115
} catch (const std::out_of_range&) {
116116
assert(idx == 0);

0 commit comments

Comments
 (0)