Skip to content

Commit 848c6ba

Browse files
Fixing implementation of DPP subgroup reduce
Signed-off-by: Muzammiluddin Syed <[email protected]>
1 parent 6442288 commit 848c6ba

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ struct VectorSubgroupReduceToShuffles final
368368
};
369369

370370
FailureOr<Value>
371-
createSubgroupDPPReduction(PatternRewriter &rewriter, gpu::SubgroupReduceOp &op,
371+
createSubgroupDPPReduction(PatternRewriter &rewriter, gpu::SubgroupReduceOp op,
372372
Value input, gpu::AllReduceOperation mode,
373373
const ClusterInfo &ci, amdgpu::Chipset chipset) {
374374
Location loc = op.getLoc();
@@ -435,7 +435,7 @@ createSubgroupDPPReduction(PatternRewriter &rewriter, gpu::SubgroupReduceOp &op,
435435
if (ci.subgroupSize == 32) {
436436
Value lane0 = rewriter.create<arith::ConstantOp>(
437437
loc, rewriter.getI32Type(), rewriter.getI32IntegerAttr(0));
438-
dpp =
438+
res =
439439
rewriter.create<ROCDL::ReadlaneOp>(loc, res.getType(), res, lane0);
440440
}
441441
} else {

0 commit comments

Comments
 (0)