Skip to content

Commit 852b691

Browse files
committed
[clang][CodeGen] Added !range metadata to atomic load for bool.
1 parent 4581169 commit 852b691

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

clang/lib/CodeGen/CGAtomic.cpp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,6 +590,29 @@ static void EmitAtomicOp(CodeGenFunction &CGF, AtomicExpr *E, Address Dest,
590590
llvm::LoadInst *Load = CGF.Builder.CreateLoad(Ptr);
591591
Load->setAtomic(Order, Scope);
592592
Load->setVolatile(E->isVolatile());
593+
594+
if (CGF.CGM.getCodeGenOpts().OptimizationLevel == 0) {
595+
CGF.Builder.CreateStore(Load, Dest);
596+
return;
597+
}
598+
599+
QualType Ty = E->getValueType();
600+
if (!Ty->isBooleanType()) {
601+
CGF.Builder.CreateStore(Load, Dest);
602+
return;
603+
}
604+
605+
llvm::MDBuilder MDHelper(CGF.getLLVMContext());
606+
llvm::APInt BooleanMin = llvm::APInt(CGF.getContext().getTypeSize(Ty), 0);
607+
llvm::APInt BooleanEnd = llvm::APInt(CGF.getContext().getTypeSize(Ty), 2);
608+
609+
if (llvm::MDNode *RangeInfo =
610+
MDHelper.createRange(BooleanMin, BooleanEnd)) {
611+
Load->setMetadata(llvm::LLVMContext::MD_range, RangeInfo);
612+
Load->setMetadata(llvm::LLVMContext::MD_noundef,
613+
llvm::MDNode::get(CGF.getLLVMContext(), {}));
614+
}
615+
593616
CGF.Builder.CreateStore(Load, Dest);
594617
return;
595618
}

clang/test/CodeGen/atomic-ops-load.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
extern bool t1;
55
bool test1(void) {
66
// CHECK-LABEL: define{{.*}} i1 @test1
7-
// CHECK: load atomic i8, ptr @t1 monotonic, align 1
8-
// CHECK-NEXT: trunc i8 %{{.*}} to i1
7+
// CHECK: load atomic i8, ptr @t1 monotonic, align 1, !range ![[$WS_RANGE:[0-9]*]], !noundef !{{[0-9]+}}
8+
// CHECK-NEXT: trunc nuw i8 %{{.*}} to i1
99
// CHECK-NEXT: ret i1 %{{.*}}
1010
return __atomic_load_n(&t1, __ATOMIC_RELAXED);
1111
}

0 commit comments

Comments
 (0)