remove isdPartiallySubstituted, add comments

Author: cor3ntin

clang/include/clang/AST/ExprCXX.h

@@ -4547,12 +4547,9 @@ class PackIndexingExpr final
   static PackIndexingExpr *CreateDeserialized(ASTContext &Context,
                                               unsigned NumTransformedExprs);
 
+  // The index expression and all elements of the pack have been substituted.
   bool isFullySubstituted() const { return FullySubstituted; }
 
-  bool isPartiallySubstituted() const {
-    return isValueDependent() && TransformedExpressions;
-  };
-
   /// Determine if the expression was expanded to empty.
   bool expandsToEmptyPack() const {
     return isFullySubstituted() && TransformedExpressions == 0;

clang/lib/AST/ASTContext.cpp

@@ -6446,9 +6446,9 @@ QualType ASTContext::getPackIndexingType(QualType Pattern, Expr *IndexExpr,
       void *Mem = Allocate(
           PackIndexingType::totalSizeToAlloc<QualType>(Expansions.size()),
           TypeAlignment);
-      Canon = new (Mem)
-          PackIndexingType(QualType(), Pattern.getCanonicalType(),
-                           IndexExpr, FullySubstituted, Expansions);
+      Canon =
+          new (Mem) PackIndexingType(QualType(), Pattern.getCanonicalType(),
+                                     IndexExpr, FullySubstituted, Expansions);
       DependentPackIndexingTypes.InsertNode(Canon, InsertPos);
     }
     Canonical = QualType(Canon, 0);

clang/lib/AST/StmtProfile.cpp

@@ -2293,7 +2293,7 @@ void StmtProfiler::VisitSizeOfPackExpr(const SizeOfPackExpr *S) {
 void StmtProfiler::VisitPackIndexingExpr(const PackIndexingExpr *E) {
   VisitExpr(E->getIndexExpr());
 
-  if (E->isPartiallySubstituted()) {
+  if (E->expandsToEmptyPack() || E->getExpressions().size() != 0) {
     ID.AddInteger(E->getExpressions().size());
     for (const Expr *Sub : E->getExpressions())
       Visit(Sub);

clang/lib/AST/Type.cpp

@@ -4176,7 +4176,8 @@ PackIndexingType::computeDependence(QualType Pattern, Expr *IndexExpr,
 
 void PackIndexingType::Profile(llvm::FoldingSetNodeID &ID,
                                const ASTContext &Context) {
-  Profile(ID, Context, getPattern(), getIndexExpr(), isFullySubstituted(), getExpansions());
+  Profile(ID, Context, getPattern(), getIndexExpr(), isFullySubstituted(),
+          getExpansions());
 }
 
 void PackIndexingType::Profile(llvm::FoldingSetNodeID &ID,
@@ -4186,12 +4187,11 @@ void PackIndexingType::Profile(llvm::FoldingSetNodeID &ID,
 
   E->Profile(ID, Context, true);
   ID.AddBoolean(FullySubstituted);
-  if(!Expansions.empty()) {
+  if (!Expansions.empty()) {
     ID.AddInteger(Expansions.size());
-    for(QualType T : Expansions)
+    for (QualType T : Expansions)
       T.getCanonicalType().Profile(ID);
-  }
-  else {
+  } else {
     Pattern.Profile(ID);
   }
 }