clean up

Author: joaosaffran

llvm/include/llvm/MC/DXContainerRootSignature.h

@@ -7,19 +7,17 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/BinaryFormat/DXContainer.h"
-#include "llvm/Support/raw_ostream.h"
 
 namespace llvm {
 
 class raw_ostream;
 
 namespace mcdxbc {
-
 struct RootSignatureDesc {
   dxbc::RootSignatureHeader Header;
   SmallVector<dxbc::RootParameter> Parameters;
 
-  Error write(raw_ostream &OS) const;
+  void write(raw_ostream &OS) const;
 };
 } // namespace mcdxbc
 } // namespace llvm

llvm/lib/MC/DXContainerRootSignature.cpp

@@ -7,11 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/MC/DXContainerRootSignature.h"
-#include "llvm/ADT/SmallVector.h"
-#include "llvm/ADT/Twine.h"
 #include "llvm/Support/EndianStream.h"
-#include "llvm/Support/Error.h"
-#include <cstdint>
 
 using namespace llvm;
 using namespace llvm::mcdxbc;
@@ -28,7 +24,7 @@ void rewriteOffset(buffer_ostream &Stream, uint32_t Offset) {
   support::endian::write(InsertPoint, Value, llvm::endianness::little);
 }
 
-Error RootSignatureDesc::write(raw_ostream &OS) const {
+void RootSignatureDesc::write(raw_ostream &OS) const {
   buffer_ostream Writer(OS);
   const uint32_t NumParameters = Parameters.size();
   const uint32_t Zero = 0;
@@ -75,6 +71,4 @@ Error RootSignatureDesc::write(raw_ostream &OS) const {
       llvm_unreachable("Invalid RootParameterType");
     }
   }
-
-  return Error::success();
 }

llvm/lib/ObjectYAML/DXContainerEmitter.cpp

@@ -271,8 +271,7 @@ void DXContainerWriter::writeParts(raw_ostream &OS) {
       RS.Header.Version = P.RootSignature->Version;
       RS.Parameters = std::move(P.RootSignature->Parameters);
 
-      if (Error Err = RS.write(OS))
-        handleAllErrors(std::move(Err));
+      RS.write(OS);
 
       break;
     }

llvm/lib/Target/DirectX/DXContainerGlobals.cpp

@@ -25,12 +25,10 @@
 #include "llvm/InitializePasses.h"
 #include "llvm/MC/DXContainerPSVInfo.h"
 #include "llvm/Pass.h"
-#include "llvm/Support/Error.h"
 #include "llvm/Support/MD5.h"
 #include "llvm/TargetParser/Triple.h"
 #include "llvm/Transforms/Utils/ModuleUtils.h"
 #include <optional>
-#include <utility>
 
 using namespace llvm;
 using namespace llvm::dxil;
@@ -175,8 +173,7 @@ void DXContainerGlobals::addRootSignature(Module &M,
   SmallString<256> Data;
   raw_svector_ostream OS(Data);
 
-  if (Error Err = RS.write(OS))
-    handleAllErrors(std::move(Err));
+  RS.write(OS);
 
   Constant *Constant =
       ConstantDataArray::getString(M.getContext(), Data, /*AddNull*/ false);