Skip to content

Commit 85f8b0b

Browse files
committed
fixup! Use the set difference operator to calculate 'other_categories'
1 parent 8739406 commit 85f8b0b

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

lldb/packages/Python/lldbsuite/test/lldbtest.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1779,18 +1779,13 @@ def no_reason(_):
17791779
):
17801780
# If any debug info categories were explicitly tagged, assume that list to be
17811781
# authoritative. If none were specified, try with all debug info formats.
1782-
test_method_categories = getattr(attrvalue, "categories", [])
1783-
dbginfo_categories = set(test_method_categories) & set(
1782+
test_method_categories = set(getattr(attrvalue, "categories", []))
1783+
all_dbginfo_categories = set(
17841784
test_categories.debug_info_categories.keys()
17851785
)
1786-
if dbginfo_categories:
1787-
other_categories = [
1788-
category
1789-
for category in test_method_categories
1790-
if category not in dbginfo_categories
1791-
]
1792-
else:
1793-
other_categories = test_method_categories
1786+
dbginfo_categories = test_method_categories & all_dbginfo_categories
1787+
other_categories = list(test_method_categories - all_dbginfo_categories)
1788+
if not dbginfo_categories:
17941789
dbginfo_categories = [
17951790
category
17961791
for category, can_replicate in test_categories.debug_info_categories.items()

0 commit comments

Comments
 (0)