Remove check on CodeGenOpt::XRayInstrumentFunctions

mshockwave · mshockwave · commit 870cc2299e67 · 2024-11-21T11:57:09.000-08:00
When adding XRayPreparationPass. Because for some reason, both
CodeGenOpt::XRayInstrumentFunctions and LangOpt::XRayInstrument are set
to the wrong value in BackendUtil.
diff --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp
@@ -1063,8 +1063,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
       });
     }
 
-    if (CodeGenOpts.XRayInstrumentFunctions &&
-        !CodeGenOpts.XRayDefaultOptions.empty()) {
+    if (!CodeGenOpts.XRayDefaultOptions.empty()) {
       PB.registerOptimizerLastEPCallback(
           [](ModulePassManager &MPM, OptimizationLevel Level,
              ThinOrFullLTOPhase) { MPM.addPass(XRayPreparationPass()); });

Original file line number	Diff line number	Diff line change
`@@ -1063,8 +1063,7 @@ void EmitAssemblyHelper::RunOptimizationPipeline(`
`1063`	`1063`	`});`
`1064`	`1064`	`}`
`1065`	`1065`
`1066`		`- if (CodeGenOpts.XRayInstrumentFunctions &&`
`1067`		`- !CodeGenOpts.XRayDefaultOptions.empty()) {`
	`1066`	`+ if (!CodeGenOpts.XRayDefaultOptions.empty()) {`
`1068`	`1067`	`PB.registerOptimizerLastEPCallback(`
`1069`	`1068`	`[](ModulePassManager &MPM, OptimizationLevel Level,`
`1070`	`1069`	`ThinOrFullLTOPhase) { MPM.addPass(XRayPreparationPass()); });`