File tree Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -166,12 +166,12 @@ class Value {
166166 // TODO: the GetScalar() API relies on knowledge not codified by the type
167167 // system, making it hard to understand and easy to misuse.
168168 // - Separate the scalar from the variable that contains the address (be it a
169- // load, file or host address).
169+ // load, file or host address).
170170 // - Rename GetScalar() to something more indicative to what the scalar is,
171- // like GetScalarOrAddress() for example.
171+ // like GetScalarOrAddress() for example.
172172 // - Split GetScalar() into two functions, GetScalar() and GetAddress(), which
173- // verify (or assert) what m_value_type is to make sure users of the class are
174- // querying the right thing.
173+ // verify (or assert) what m_value_type is to make sure users of the class are
174+ // querying the right thing.
175175 // TODO: It's confusing to point to multiple possible buffers when the
176176 // ValueType is a host address. Value should probably always own its buffer.
177177 // Perhaps as a shared pointer with a copy on write system if the same buffer
You can’t perform that action at this time.
0 commit comments