Commit 87f1d60
committed
Remove an incorrect assert in MFMASmallGemmSingleWaveOpt.
This assert was failing in a fuzzing test. I consulted with @jrbyrnes who said:
The MFMASmallGemmSingleWaveOpt::apply() method is invoked if and only if the
user has inserted an intrinsic llvm.amdgcn.iglp.opt(i32 1) into their source
code. This intrinsic applies a highly specialized DAG mutation to result in
specific scheduling for a specific set of kernels. These assertions are really
just confirming that the characteristics of the kernel match what is expected
(i.e. The kernels are similar to the ones this DAG mutation strategy were
designed against).
However, if we apply this DAG mutation to kernels for which is was not
designed, then we may not find the types of instructions we are looking for,
and may end up with empty caches.
I think it should be fine to just return false if the cache is empty instead
of the assert.1 parent 3c74262 commit 87f1d60
1 file changed
+0
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1891 | 1891 | | |
1892 | 1892 | | |
1893 | 1893 | | |
1894 | | - | |
1895 | 1894 | | |
1896 | 1895 | | |
1897 | 1896 | | |
| |||
0 commit comments