Skip to content

Commit 881a8a5

Browse files
committed
make sure Lincoln is not a rhino
1 parent 4a92789 commit 881a8a5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1443,7 +1443,7 @@ def LLVM_GlobalCtorsOp : LLVM_Op<"mlir.global_ctors", [
14431443
ArrayAttr:$data);
14441444
let summary = "LLVM dialect global_ctors.";
14451445
let description = [{
1446-
Specifies a list of constructor functions, priorities and associated data.
1446+
Specifies a list of constructor functions, priorities, and associated data.
14471447
The functions referenced by this array will be called in ascending order
14481448
of priority (i.e. lowest first) when the module is loaded. The order of
14491449
functions with the same priority is not defined. This operation is

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2513,7 +2513,7 @@ LogicalResult checkGlobalXtorData(Operation *op, ArrayAttr data) {
25132513
return success();
25142514

25152515
if (llvm::all_of(data.getAsRange<Attribute>(), [](Attribute v) {
2516-
return isa<FlatSymbolRefAttr>(v) || isa<ZeroAttr>(v);
2516+
return isa<FlatSymbolRefAttr, ZeroAttr>(v);
25172517
}))
25182518
return success();
25192519
return op->emitError("data element must be symbol or #llvm.zero");
@@ -2537,7 +2537,7 @@ LogicalResult GlobalCtorsOp::verify() {
25372537
getCtors().size() == getData().size())
25382538
return success();
25392539
return emitError(
2540-
"ctors, priorities and data must have the same number of elements");
2540+
"ctors, priorities, and data must have the same number of elements");
25412541
}
25422542

25432543
//===----------------------------------------------------------------------===//
@@ -2562,7 +2562,7 @@ LogicalResult GlobalDtorsOp::verify() {
25622562
getDtors().size() == getData().size())
25632563
return success();
25642564
return emitError(
2565-
"dtors, priorities and data must have the same number of elements");
2565+
"dtors, priorities, and data must have the same number of elements");
25662566
}
25672567

25682568
//===----------------------------------------------------------------------===//

mlir/test/Dialect/LLVMIR/invalid.mlir

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ llvm.func @ctor() {
99
llvm.return
1010
}
1111

12-
// expected-error@+1{{ctors, priorities and data must have the same number of elements}}
12+
// expected-error@+1{{ctors, priorities, and data must have the same number of elements}}
1313
llvm.mlir.global_ctors ctors = [@ctor], priorities = [], data = [#llvm.zero]
1414

1515
// -----
@@ -18,7 +18,7 @@ llvm.func @dtor() {
1818
llvm.return
1919
}
2020

21-
// expected-error@+1{{dtors, priorities and data must have the same number of elements}}
21+
// expected-error@+1{{dtors, priorities, and data must have the same number of elements}}
2222
llvm.mlir.global_dtors dtors = [@dtor], priorities = [0 : i32, 32767 : i32], data = [#llvm.zero]
2323

2424
// -----

0 commit comments

Comments
 (0)