address review comments

Author: valerydmit

flang-rt/include/flang-rt/runtime/descriptor.h

@@ -511,7 +511,7 @@ class Descriptor {
   RT_API_ATTRS void Check() const;
 
   // When dumpRawType, dumps stringified CFI_type_*, otherwise
-  // try to canonicalize and pront as a Fortran type.
+  // try to canonicalize and print as a Fortran type.
   void Dump(FILE * = stdout, bool dumpRawType = true) const;
 
   RT_API_ATTRS inline bool HasAddendum() const {

flang-rt/lib/runtime/extensions.cpp

@@ -398,10 +398,9 @@ std::int64_t RTNAME(time)() { return time(nullptr); }
 // MCLOCK: returns accumulated CPU time in ticks
 std::int32_t FORTRAN_PROCEDURE_NAME(mclock)() { return std::clock(); }
 
-void RTNAME(ShowDescriptor)(const char *descr) {
+void RTNAME(ShowDescriptor)(const Fortran::runtime::Descriptor *descr) {
   if (descr) {
-    reinterpret_cast<const Fortran::runtime::Descriptor *>(descr)->Dump(
-        stderr, /*dumpRawType=*/false);
+    descr->Dump(stderr, /*dumpRawType=*/false);
   } else {
     std::fprintf(stderr, "NULL\n");
   }

flang/include/flang/Runtime/extensions.h

@@ -25,6 +25,11 @@ typedef std::uint32_t gid_t;
 #else
 #include "sys/types.h" //pid_t
 #endif
+namespace Fortran {
+namespace runtime {
+class Descriptor;
+}
+} // namespace Fortran
 
 extern "C" {
 
@@ -102,7 +107,7 @@ float FORTRAN_PROCEDURE_NAME(secnds)(float *refTime);
 float RTNAME(Secnds)(float *refTime, const char *sourceFile, int line);
 
 // Extension subroutine SHOW_DESCRIPTOR(D)
-void RTNAME(ShowDescriptor)(const char *descr);
+void RTNAME(ShowDescriptor)(const Fortran::runtime::Descriptor* descr);
 
 } // extern "C"
 #endif // FORTRAN_RUNTIME_EXTENSIONS_H_

flang/lib/Optimizer/Builder/IntrinsicCall.cpp

@@ -7820,7 +7820,7 @@ mlir::Value IntrinsicLibrary::genShiftA(mlir::Type resultType,
 
 void IntrinsicLibrary::genShowDescriptor(
     llvm::ArrayRef<fir::ExtendedValue> args) {
-  assert(args.size() == 1);
+  assert(args.size() == 1 && "expected single argument for show_descriptor");
   const mlir::Value descriptor = fir::getBase(args[0]);
 
   assert(fir::isa_box_type(descriptor.getType()) &&