Change to the getAttributesName function for our list of disallowed attributes

Author: erichkeane

clang/include/clang/CIR/Dialect/IR/CIRTypes.td

@@ -509,25 +509,6 @@ def CIR_FuncType : CIR_Type<"Func", "func"> {
     /// Returns a clone of this function type with the given argument
     /// and result types.
     FuncType clone(mlir::TypeRange inputs, mlir::TypeRange results) const;
-
-    /// A list of mlir attributes that shouldn't appear in the generic
-    /// 'attributes' list, and instead are handled via other syntax.
-    static constexpr llvm::StringRef disallowedFromAttrList[] = {
-        "alias",
-        "builtin",
-        "comdat",
-        "coroutine",
-        "cxx_special_member",
-        "dso_local",
-        "function_type",
-        "global_ctor_priority",
-        "global_dtor_priority",
-        "global_visibility",
-        "inline_kind",
-        "lambda",
-        "linkage",
-        "no_proto",
-        "sym_visibility"};
   }];
 }
 

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -1829,7 +1829,7 @@ ParseResult cir::FuncOp::parse(OpAsmParser &parser, OperationState &state) {
   if (parser.parseOptionalAttrDictWithKeyword(parsedAttrs))
     return failure();
 
-  for (StringRef disallowed : cir::FuncType::disallowedFromAttrList) {
+  for (StringRef disallowed : cir::FuncOp::getAttributeNames()) {
     if (parsedAttrs.get(disallowed))
       return parser.emitError(loc, "attribute '")
              << disallowed
@@ -1992,7 +1992,7 @@ void cir::FuncOp::print(OpAsmPrinter &p) {
   }
 
   function_interface_impl::printFunctionAttributes(
-      p, *this, cir::FuncType::disallowedFromAttrList);
+      p, *this, cir::FuncOp::getAttributeNames());
 
   // Print the body if this is not an external function.
   Region &body = getOperation()->getRegion(0);