Skip to content

Commit 8987697

Browse files
committed
Use std::abs and update test
1 parent b2ec3ad commit 8987697

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

clang/lib/Sema/SemaHLSL.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2222,7 +2222,7 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
22222222
Expr *OffsetExpr = TheCall->getArg(1);
22232223
std::optional<llvm::APSInt> Offset =
22242224
OffsetExpr->getIntegerConstantExpr(SemaRef.getASTContext());
2225-
if (!Offset.has_value() || abs(Offset->getExtValue()) != 1) {
2225+
if (!Offset.has_value() || std::abs(Offset->getExtValue()) != 1) {
22262226
SemaRef.Diag(TheCall->getArg(1)->getBeginLoc(),
22272227
diag::err_hlsl_expect_arg_const_int_one_or_neg_one)
22282228
<< 1;

llvm/test/CodeGen/DirectX/updateCounter.ll renamed to llvm/test/CodeGen/DirectX/bufferUpdateCounter.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ define void @update_counter_decrement_vector() {
1212

1313
; CHECK-NEXT: [[BUFFANOT:%.*]] = call %dx.types.Handle @dx.op.annotateHandle(i32 216, %dx.types.Handle [[BIND]]
1414
; CHECK-NEXT: [[REG:%.*]] = call i32 @dx.op.bufferUpdateCounter(i32 70, %dx.types.Handle [[BUFFANOT]], i8 -1)
15-
%1 = call i32 @llvm.dx.updateCounter(target("dx.TypedBuffer", <4 x float>, 0, 0, 0) %buffer, i8 -1)
15+
%1 = call i32 @llvm.dx.bufferUpdateCounter(target("dx.TypedBuffer", <4 x float>, 0, 0, 0) %buffer, i8 -1)
1616
ret void
1717
}
1818

@@ -24,7 +24,7 @@ define void @update_counter_increment_vector() {
2424
i32 0, i32 0, i32 1, i32 0, i1 false)
2525
; CHECK-NEXT: [[BUFFANOT:%.*]] = call %dx.types.Handle @dx.op.annotateHandle(i32 216, %dx.types.Handle [[BIND]]
2626
; CHECK-NEXT: [[REG:%.*]] = call i32 @dx.op.bufferUpdateCounter(i32 70, %dx.types.Handle [[BUFFANOT]], i8 1)
27-
%1 = call i32 @llvm.dx.updateCounter(target("dx.TypedBuffer", <4 x float>, 0, 0, 0) %buffer, i8 1)
27+
%1 = call i32 @llvm.dx.bufferUpdateCounter(target("dx.TypedBuffer", <4 x float>, 0, 0, 0) %buffer, i8 1)
2828
ret void
2929
}
3030

@@ -36,6 +36,6 @@ define void @update_counter_decrement_scalar() {
3636
i32 1, i32 8, i32 1, i32 0, i1 false)
3737
; CHECK-NEXT: [[BUFFANOT:%.*]] = call %dx.types.Handle @dx.op.annotateHandle(i32 216, %dx.types.Handle [[BIND]]
3838
; CHECK-NEXT: [[REG:%.*]] = call i32 @dx.op.bufferUpdateCounter(i32 70, %dx.types.Handle [[BUFFANOT]], i8 -1)
39-
%1 = call i32 @llvm.dx.updateCounter(target("dx.RawBuffer", i8, 0, 0) %buffer, i8 -1)
39+
%1 = call i32 @llvm.dx.bufferUpdateCounter(target("dx.RawBuffer", i8, 0, 0) %buffer, i8 -1)
4040
ret void
4141
}

0 commit comments

Comments
 (0)