resolve comments

Author: mingmingl-llvm

llvm/include/llvm/CodeGen/MachineJumpTableInfo.h

@@ -36,6 +36,8 @@ struct MachineJumpTableEntry {
   /// MBBs - The vector of basic blocks from which to create the jump table.
   std::vector<MachineBasicBlock*> MBBs;
 
+  /// The hotness of MJTE is inferred from the hotness of the source basic
+  /// block(s) that reference it.
   MachineFunctionDataHotness Hotness;
 
   explicit MachineJumpTableEntry(const std::vector<MachineBasicBlock *> &M);

llvm/lib/CodeGen/MachineFunction.cpp

@@ -1347,9 +1347,7 @@ unsigned MachineJumpTableInfo::createJumpTableIndex(
 bool MachineJumpTableInfo::updateJumpTableEntryHotness(
     size_t JTI, MachineFunctionDataHotness Hotness) {
   assert(JTI < JumpTables.size() && "Invalid JTI!");
-  // Note record the largest hotness is important for mergable data (constant
-  // pools). Even if jump table instances are not merged, record the largest
-  // value seen fwiw.
+  // Record the largest hotness value.
   if (Hotness <= JumpTables[JTI].Hotness)
     return false;
 

llvm/lib/CodeGen/StaticDataSplitter.cpp

@@ -58,7 +58,7 @@ class StaticDataSplitter : public MachineFunctionPass {
   bool splitJumpTables(MachineFunction &MF);
 
   // Same as above but works on functions with profile information.
-  bool splitJumpTablesWithProfiles(MachineFunction &MF,
+  bool splitJumpTablesWithProfiles(const MachineFunction &MF,
                                    MachineJumpTableInfo &MJTI);
 
 public:
@@ -89,7 +89,7 @@ bool StaticDataSplitter::runOnMachineFunction(MachineFunction &MF) {
 }
 
 bool StaticDataSplitter::splitJumpTablesWithProfiles(
-    MachineFunction &MF, MachineJumpTableInfo &MJTI) {
+    const MachineFunction &MF, MachineJumpTableInfo &MJTI) {
   int NumChangedJumpTables = 0;
 
   // Jump table could be used by either terminating instructions or

llvm/test/CodeGen/X86/jump-table-partition.ll

@@ -7,8 +7,8 @@
 ; RUN: llc --run-pass=static-data-splitter -stats -x mir %t.mir -o - 2>&1 | FileCheck %s --check-prefix=STAT
 
 ; Tests stat messages are expected.
-; TODO: Update test to verify section suffixes when target-lowering and assembler changes are implemented.
-; TODO: Also run static-data-splitter pass with -static-data-default-hotness=cold and check data section suffix.
+; COM: Update test to verify section suffixes when target-lowering and assembler changes are implemented.
+; COM: Also run static-data-splitter pass with -static-data-default-hotness=cold and check data section suffix.
 
 ; STAT-DAG: 2 static-data-splitter - Number of cold jump tables seen
 ; STAT-DAG: 2 static-data-splitter - Number of hot jump tables seen