Skip to content

Commit 8a0b3cc

Browse files
[CI] Ignore upload artifact failures (#154196)
Some CI runs are seeing issues with failures running the artifact upload step. They seem related to actions/upload-artifact#569. We should continue the workflow and ignore errors in the upload artifact step if it fails so that users do not see a red CI that is not due to their changes. Fixes #154155.
1 parent 89abccc commit 8a0b3cc

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

.github/workflows/premerge.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,11 @@ jobs:
6969
7070
./.ci/monolithic-linux.sh "${projects_to_build}" "${project_check_targets}" "${runtimes_to_build}" "${runtimes_check_targets}" "${runtimes_check_targets_needs_reconfig}" "${enable_cir}"
7171
- name: Upload Artifacts
72+
# In some cases, Github will fail to upload the artifact. We want to
73+
# continue anyways as a failed artifact upload is an infra failure, not
74+
# a checks failure.
75+
# https://github.com/actions/upload-artifact/issues/569
76+
continue-on-error: true
7277
if: '!cancelled()'
7378
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
7479
with:
@@ -114,6 +119,11 @@ jobs:
114119
# these environment variables.
115120
bash -c "export SCCACHE_GCS_BUCKET=$CACHE_GCS_BUCKET; export SCCACHE_GCS_RW_MODE=READ_WRITE; export SCCACHE_IDLE_TIMEOUT=0; sccache --start-server; .ci/monolithic-windows.sh \"${{ steps.vars.outputs.windows-projects }}\" \"${{ steps.vars.outputs.windows-check-targets }}\""
116121
- name: Upload Artifacts
122+
# In some cases, Github will fail to upload the artifact. We want to
123+
# continue anyways as a failed artifact upload is an infra failure, not
124+
# a checks failure.
125+
# https://github.com/actions/upload-artifact/issues/569
126+
continue-on-error: true
117127
if: '!cancelled()'
118128
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
119129
with:

0 commit comments

Comments
 (0)