inverse StrictMode option

Author: denzor200

clang-tools-extra/clang-tidy/misc/BoolBitwiseOperationCheck.cpp

@@ -71,7 +71,7 @@ static std::string translate(llvm::StringRef Value) {
 BoolBitwiseOperationCheck::BoolBitwiseOperationCheck(StringRef Name,
                                                      ClangTidyContext *Context)
     : ClangTidyCheck(Name, Context),
-      StrictMode(Options.get("StrictMode", true)),
+      StrictMode(Options.get("StrictMode", false)),
       IgnoreMacros(Options.get("IgnoreMacros", false)) {}
 
 void BoolBitwiseOperationCheck::storeOptions(
@@ -114,8 +114,8 @@ void BoolBitwiseOperationCheck::check(const MatchFinder::MatchResult &Result) {
   if (HasVolatileOperand)
     return;
 
-  const bool HasSideEffects =
-      MatchedExpr->getRHS()->HasSideEffects(*Result.Context, StrictMode);
+  const bool HasSideEffects = MatchedExpr->getRHS()->HasSideEffects(
+      *Result.Context, /*IncludePossibleEffects=*/!StrictMode);
   if (HasSideEffects)
     return;
 

clang-tools-extra/docs/clang-tidy/checks/misc/bool-bitwise-operation.rst

@@ -38,8 +38,8 @@ Options
 
 .. option:: StrictMode
 
-    Disabling this option promotes more fix-it hints even when they might
-    change evaluation order or skip side effects. Default value is `true`.
+    Enabling this option promotes more fix-it hints even when they might
+    change evaluation order or skip side effects. Default value is `false`.
 
 .. option:: IgnoreMacros
 

clang-tools-extra/test/clang-tidy/checkers/misc/bool-bitwise-operation-change-possible-side-effect.cpp

@@ -1,6 +1,6 @@
 // RUN: %check_clang_tidy %s misc-bool-bitwise-operation %t \
 // RUN:   -config="{CheckOptions: { \
-// RUN:     misc-bool-bitwise-operation.StrictMode: false }}"
+// RUN:     misc-bool-bitwise-operation.StrictMode: true }}"
 
 bool function_with_possible_side_effects();