Also fix a return in ClangFormat.cpp

owenca · web-flow · commit 8a5c1561c7ee · 2024-10-24T20:38:41.000-07:00
diff --git a/clang/tools/clang-format/ClangFormat.cpp b/clang/tools/clang-format/ClangFormat.cpp
@@ -410,7 +410,7 @@ static bool format(StringRef FileName, bool ErrorOnIncompleteFormat = false) {
   const bool IsSTDIN = FileName == "-";
   if (!OutputXML && Inplace && IsSTDIN) {
     errs() << "error: cannot use -i when reading from stdin.\n";
-    return false;
+    return true;
   }
   // On Windows, overwriting a file with an open file mapping doesn't work,
   // so read the whole file into memory when formatting in-place.

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ static bool format(StringRef FileName, bool ErrorOnIncompleteFormat = false) {`
`410`	`410`	`const bool IsSTDIN = FileName == "-";`
`411`	`411`	`if (!OutputXML && Inplace && IsSTDIN) {`
`412`	`412`	`errs() << "error: cannot use -i when reading from stdin.\n";`
`413`		`- return false;`
	`413`	`+ return true;`
`414`	`414`	`}`
`415`	`415`	`// On Windows, overwriting a file with an open file mapping doesn't work,`
`416`	`416`	`// so read the whole file into memory when formatting in-place.`