remove FIXME, delete comment

androm3da · androm3da · commit 8a97197555bf · 2025-07-20T09:42:26.000-05:00
diff --git a/lld/ELF/Arch/Hexagon.cpp b/lld/ELF/Arch/Hexagon.cpp
@@ -301,7 +301,6 @@ bool Hexagon::needsThunk(RelExpr expr, RelType type, const InputFile *file,
   case R_HEX_B9_PCREL:
     return !ctx.target->inBranchRange(type, branchAddr, s.getVA(ctx, a));
   default:
-    // For unsupported relocation types, no thunk is needed
     return false;
   }
 }
diff --git a/lld/ELF/Thunks.cpp b/lld/ELF/Thunks.cpp
@@ -1538,7 +1538,7 @@ bool PPC64LongBranchThunk::isCompatibleWith(const InputSection &isec,
 // Hexagon Target Thunks
 static uint64_t getHexagonThunkDestVA(Ctx &ctx, const Symbol &s, int64_t a) {
   uint64_t v = s.isInPlt(ctx) ? s.getPltVA(ctx) : s.getVA(ctx, a);
-  return SignExtend64<32>(v); // FIXME: sign extend to 64-bit?
+  return SignExtend64<32>(v);
 }
 
 void HexagonThunk::writeTo(uint8_t *buf) {

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,6 @@ bool Hexagon::needsThunk(RelExpr expr, RelType type, const InputFile *file,`
`301`	`301`	`case R_HEX_B9_PCREL:`
`302`	`302`	`return !ctx.target->inBranchRange(type, branchAddr, s.getVA(ctx, a));`
`303`	`303`	`default:`
`304`		`- // For unsupported relocation types, no thunk is needed`
`305`	`304`	`return false;`
`306`	`305`	`}`
`307`	`306`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1538,7 +1538,7 @@ bool PPC64LongBranchThunk::isCompatibleWith(const InputSection &isec,`
`1538`	`1538`	`// Hexagon Target Thunks`
`1539`	`1539`	`static uint64_t getHexagonThunkDestVA(Ctx &ctx, const Symbol &s, int64_t a) {`
`1540`	`1540`	`uint64_t v = s.isInPlt(ctx) ? s.getPltVA(ctx) : s.getVA(ctx, a);`
`1541`		`- return SignExtend64<32>(v); // FIXME: sign extend to 64-bit?`
	`1541`	`+ return SignExtend64<32>(v);`
`1542`	`1542`	`}`
`1543`	`1543`
`1544`	`1544`	`void HexagonThunk::writeTo(uint8_t *buf) {`