Skip to content

Commit 8ac6d5b

Browse files
committed
Comment cleanup on the 0 bytes read error case
1 parent 1cfd90c commit 8ac6d5b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -998,7 +998,8 @@ Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
998998
"Failed to read memory region at: %" PRIx64
999999
". Bytes read: %zu, error: %s",
10001000
addr, bytes_read_for_chunk, error.AsCString());
1001-
// If we've only read one byte we can just give up and return
1001+
// If we've read nothing, and get an error or fail to read
1002+
// we can just give up early.
10021003
if (total_bytes_read == 0)
10031004
return Status();
10041005

0 commit comments

Comments
 (0)