Skip to content

Commit 8acd46e

Browse files
committed
add fixmes
1 parent 4ca083d commit 8acd46e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

clang/lib/Sema/SemaConcept.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,6 +754,7 @@ ExprResult CalculateConstraintSatisfaction::Calculate(
754754

755755
llvm::SmallVector<TemplateArgument> SubstitutedOuterMost;
756756
// FIXME: Is PackSubstitutionIndex correct?
757+
// TODO: We might want to cache the substitution of fold expanded constraints.
757758
llvm::SaveAndRestore _(PackSubstitutionIndex, S.ArgPackSubstIndex);
758759
std::optional<MultiLevelTemplateArgumentList> SubstitutedArgs =
759760
SubstitutionInTemplateArguments(
@@ -832,6 +833,8 @@ ExprResult CalculateConstraintSatisfaction::Calculate(
832833
if (Satisfaction.IsSatisfied)
833834
return E;
834835

836+
// TODO: We might want to cache the substitution of concept id constraints
837+
// as it can be slow in the SFINAE case.
835838
llvm::SmallVector<TemplateArgument> SubstitutedOuterMost;
836839
std::optional<MultiLevelTemplateArgumentList> SubstitutedArgs =
837840
SubstitutionInTemplateArguments(Constraint, MLTAL, SubstitutedOuterMost);

0 commit comments

Comments
 (0)