Skip to content

Commit 8b03b3b

Browse files
committed
MIPS: Avoid MCSymbol::isUnset
The unset state will be merged into the undefined state, so isUnset should be avoided. The code used by register equating uses the inaccurate condition. ``` .set r1, $4 ``` For now just use isUndefined. GNU Assembler has a warning: ``` Warning: register value used as expression ```
1 parent d1ee636 commit 8b03b3b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6654,7 +6654,7 @@ bool MipsAsmParser::searchSymbolAlias(OperandVector &Operands) {
66546654
llvm_unreachable("Should never fail");
66556655
}
66566656
}
6657-
} else if (Sym->isUnset()) {
6657+
} else if (Sym->isUndefined()) {
66586658
// If symbol is unset, it might be created in the `parseSetAssignment`
66596659
// routine as an alias for a numeric register name.
66606660
// Lookup in the aliases list.

0 commit comments

Comments
 (0)