Skip to content

Commit 8b757b1

Browse files
committed
add comment, address feedback
Signed-off-by: Sarnie, Nick <[email protected]>
1 parent ca1fa92 commit 8b757b1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

clang/lib/Sema/SemaDeclAttr.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5524,6 +5524,10 @@ bool Sema::CheckCallingConvAttr(const ParsedAttr &Attrs, CallingConv &CC,
55245524
A = DeviceTI->checkCallingConvention(CC);
55255525
} else if (LangOpts.SYCLIsDevice && TI.getTriple().isAMDGPU() &&
55265526
CC == CC_X86VectorCall) {
5527+
// Assuming SYCL Device AMDGPU CC_X86VectorCall functions are always to be
5528+
// emitted on the host. The MSVC STL has CC-based specializations so we
5529+
// cannot change the CC to be the default as that will cause a clash with
5530+
// another specialization.
55275531
A = TI.checkCallingConvention(CC);
55285532
if (Aux && A != TargetInfo::CCCR_OK)
55295533
A = Aux->checkCallingConvention(CC);

0 commit comments

Comments
 (0)