address comments

Author: joaosaffran

llvm/lib/Target/DirectX/DXILRootSignature.cpp

@@ -192,9 +192,8 @@ static bool validate(LLVMContext *Ctx, const mcdxbc::RootSignatureDesc &RSD) {
       return reportValueError(Ctx, "ShaderVisibility",
                               (uint32_t)P.Header.ShaderVisibility);
 
-    if (!verifyParameterType(P.Header.ParameterType))
-      return reportValueError(Ctx, "ParameterType",
-                              (uint32_t)P.Header.ParameterType);
+    assert(verifyParameterType(P.Header.ParameterType) &&
+           "Invalid value for ParameterType");
   }
 
   return false;

llvm/test/CodeGen/DirectX/ContainerData/RootSignature-Flags-Validation-Error.ll renamed to llvm/test/CodeGen/DirectX/ContainerData/RootSignature-Parameters-Validation-Error.ll

@@ -16,6 +16,5 @@ attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
 
 !dx.rootsignatures = !{!2} ; list of function/root signature pairs
 !2 = !{ ptr @main, !3 } ; function, root signature
-!3 = !{ !4, !5 } ; list of root signature elements
-!4 = !{ !"RootFlags", i32 1 } ; 1 = allow_input_assembler_input_layout
+!3 = !{ !5 } ; list of root signature elements
 !5 = !{ !"RootConstants", i32 255, i32 1, i32 2, i32 3 }