address comments

Author: matthias-springer

mlir/include/mlir/IR/Builders.h

@@ -570,7 +570,7 @@ class OpBuilder : public Builder {
   /// Note: This function does not erase the operation on a successful fold.
   LogicalResult
   tryFold(Operation *op, SmallVectorImpl<Value> &results,
-          SmallVector<Operation *> *materializedConstants = nullptr);
+          SmallVectorImpl<Operation *> *materializedConstants = nullptr);
 
   /// Creates a deep copy of the specified operation, remapping any operands
   /// that use values outside of the operation using the map that is provided

mlir/lib/IR/Builders.cpp

@@ -467,7 +467,7 @@ Operation *OpBuilder::create(Location loc, StringAttr opName,
 
 LogicalResult
 OpBuilder::tryFold(Operation *op, SmallVectorImpl<Value> &results,
-                   SmallVector<Operation *> *materializedConstants) {
+                   SmallVectorImpl<Operation *> *materializedConstants) {
   assert(results.empty() && "expected empty results");
   ResultRange opResults = op->getResults();
 

mlir/lib/Transforms/Utils/DialectConversion.cpp

@@ -2097,7 +2097,7 @@ OperationLegalizer::legalizeWithFold(Operation *op,
 
   // Try to fold the operation.
   SmallVector<Value, 2> replacementValues;
-  SmallVector<Operation *> newOps;
+  SmallVector<Operation *, 2> newOps;
   rewriter.setInsertionPoint(op);
   if (failed(rewriter.tryFold(op, replacementValues, &newOps))) {
     LLVM_DEBUG(logFailure(rewriterImpl.logger, "unable to fold"));