Address comments.

Author: lntue

libc/src/__support/FPUtil/double_double.h

@@ -25,7 +25,7 @@ template <> struct DefaultSplit<float> {
   static constexpr size_t VALUE = 12;
 };
 template <> struct DefaultSplit<double> {
-  static constexpr size_t VALUE = 27;
+  static constexpr size_t VALUE = DEFAULT_DOUBLE_SPLIT;
 };
 
 using DoubleDouble = NumberPair<double>;

libc/src/math/generic/atan2f_float.h

@@ -148,8 +148,8 @@ LLVM_LIBC_FUNCTION(float, atan2f, (float y, float x)) {
   bool recip = x_abs < y_abs;
   uint32_t min_abs = recip ? x_abs : y_abs;
   uint32_t max_abs = !recip ? x_abs : y_abs;
-  unsigned min_exp = static_cast<unsigned>(min_abs >> FPBits::FRACTION_LEN);
-  unsigned max_exp = static_cast<unsigned>(max_abs >> FPBits::FRACTION_LEN);
+  auto min_exp = static_cast<unsigned>(min_abs >> FPBits::FRACTION_LEN);
+  auto max_exp = static_cast<unsigned>(max_abs >> FPBits::FRACTION_LEN);
 
   float num = FPBits(min_abs).get_val();
   float den = FPBits(max_abs).get_val();
@@ -205,10 +205,9 @@ LLVM_LIBC_FUNCTION(float, atan2f, (float y, float x)) {
   unsigned exp_diff = max_exp - min_exp;
   // We have the following bound for normalized n and d:
   //   2^(-exp_diff - 1) < n/d < 2^(-exp_diff + 1).
-  if (LIBC_UNLIKELY(exp_diff > 25)) {
+  if (LIBC_UNLIKELY(exp_diff > 25))
     return fputil::multiply_add(final_sign, const_term.hi,
                                 final_sign * (const_term.lo + num / den));
-  }
 
   float k = fputil::nearest_integer(16.0f * num / den);
   unsigned idx = static_cast<unsigned>(k);

libc/src/math/generic/pow.cpp

@@ -400,7 +400,7 @@ LLVM_LIBC_FUNCTION(double, pow, (double x, double y)) {
 #else
   double c = FPBits(m_x.uintval() & 0x3fff'e000'0000'0000).get_val();
   dx = fputil::multiply_add(RD[idx_x], m_x.get_val() - c, CD[idx_x]); // Exact
-  dx_c0 = fputil::exact_mult<28>(dx, COEFFS[0]);                      // Exact
+  dx_c0 = fputil::exact_mult<double, 28>(dx, COEFFS[0]);              // Exact
 #endif // LIBC_TARGET_CPU_HAS_FMA
 
   double dx2 = dx * dx;