Addressreview notes

Author: spavloff

clang/lib/Sema/AnalysisBasedWarnings.cpp

@@ -480,6 +480,7 @@ struct TransferFunctions : public StmtVisitor<TransferFunctions> {
       }
       Visit(Obj);
     }
+    VisitCallExpr(CE);
   }
 
   void VisitLambdaExpr(LambdaExpr *LE) {
@@ -495,12 +496,11 @@ struct TransferFunctions : public StmtVisitor<TransferFunctions> {
     Visit(MTE->getSubExpr());
   }
 
-  void VisitExprWithCleanups(FullExpr *FE) {
-    Visit(FE->getSubExpr());
-  }
+  void VisitExprWithCleanups(FullExpr *FE) { Visit(FE->getSubExpr()); }
 
   void VisitCXXConstructExpr(CXXConstructExpr *CE) {
-    Visit(CE->getArg(0));
+    if (CE->getNumArgs() > 0)
+      Visit(CE->getArg(0));
   }
 };
 } // namespace

clang/test/SemaCXX/noreturn-vars.cpp

@@ -226,15 +226,49 @@ extern void abc_02(func_type *);
   func_ptr();
 } // expected-warning {{function declared 'noreturn' should not return}}
 
-[[noreturn]] void test_lambda() {
+[[noreturn]] void test_lambda_capture_ref() {
   func_type func_ptr = noret;
   [&func_ptr]() { func_ptr = ordinary; } ();
   func_ptr();
 } // expected-warning {{function declared 'noreturn' should not return}}
 
-[[noreturn]] void test_lambda_var(int x) {
+[[noreturn]] void test_lambda_var_capture_ref() {
   func_type func_ptr = noret;
-  auto LF = [&](){func_ptr = ordinary;};
+  auto LF = [&func_ptr](){func_ptr = ordinary; };
   LF();
   func_ptr();
 } // expected-warning {{function declared 'noreturn' should not return}}
+
+[[noreturn]] void test_lambda_capture_ref_all() {
+  func_type func_ptr = noret;
+  [&]() { func_ptr = ordinary; } ();
+  func_ptr();
+} // expected-warning {{function declared 'noreturn' should not return}}
+
+[[noreturn]] void test_lambda_var_capture_ref_all() {
+  func_type func_ptr = noret;
+  auto LF = [&](){func_ptr = ordinary; };
+  LF();
+  func_ptr();
+} // expected-warning {{function declared 'noreturn' should not return}}
+
+[[noreturn]] void lambda_capture_by_value() {
+  func_type func_ptr = noret;
+  auto LF = [func_ptr](){ return func_ptr; };
+  LF();
+  func_ptr();
+}
+
+[[noreturn]] void lambda_pass_by_ref() {
+  func_type func_ptr = noret;
+  auto LF = [](func_type &fptr){ fptr = ordinary; };
+  LF(func_ptr);
+  func_ptr();
+} // expected-warning {{function declared 'noreturn' should not return}}
+
+[[noreturn]] void lambda_pass_by_value() {
+  func_type func_ptr = noret;
+  auto LF = [](func_type fptr){ fptr = ordinary; };
+  LF(func_ptr);
+  func_ptr();
+}